DS-489 twig deprecations #2261
Merged
DS-489 twig deprecations #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dot notation does some fancy magic behind the scenes. Read more here: https://twig.symfony.com/doc/2.x/templates.html Something that was added in Twig 2.x, when using foo.bar, it will check for a `hasBar` method on the underlying object if `bar` is not a property of it. In this case, `hasClass` is a method, but not one we intend to ever call. This syntax makes that clear to twig, I think.
See https://twig.symfony.com/doc/1.x/deprecated.html#macros > As of Twig 2.0, macros imported in a file are not available in child > templates anymore (via an include call for instance). You need to > import macros explicitly in each file where you are using them.
The implemented/extended classes here were deprecated well before this code was originally written in 2018, in #426. In any case, \Twig\Extension\GlobalsInterface is needed to for the getGlobals() method to work now. See https://twig.symfony.com/doc/2.x/advanced.html
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/DS-489-twig-deprecations--branch-preview
|
@remydenton this all looks good, I didn't review the PHP files because I really can't tell if they are correct (maybe @andrewmriv can peek at them?). But I reviewed all the twig file updates and is seems like there was four types of changes, let me know if I got these correct. Twig 1 to Twig 2 changes
|
andrewmriv
approved these changes
Jul 12, 2021
packages/twig-integration/twig-extensions-shared/src/Layout/GridCellNode.php
Outdated
Show resolved
Hide resolved
colbytcook
temporarily deployed
to
feature/DS-489-twig-deprecations--branch-preview
colbytcook
temporarily deployed
to
feature/DS-489-twig-deprecations--branch-preview
colbytcook
requested a deployment
to
feature/DS-489-twig-deprecations--branch-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-489
Summary
Replaces deprecated twig syntax and usages
Details
A subset of commits from #2258, this PR is all the work that should be 100% backward compatible and can be merged while still using twig 1.
How to test
Confirm no regressions in pattern lab