Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-489 twig deprecations #2261

Merged
merged 9 commits into from
Jul 15, 2021
Merged

Commits on Jul 8, 2021

  1. Configuration menu
    Copy the full SHA
    c593a50 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    297fd9f View commit details
    Browse the repository at this point in the history
  3. DS-489: Fix .class syntax

    Dot notation does some fancy magic behind the scenes.  Read more here:
    https://twig.symfony.com/doc/2.x/templates.html
    
    Something that was added in Twig 2.x, when using foo.bar, it will check
    for a `hasBar` method on the underlying object if `bar` is not a property
    of it.  In this case, `hasClass` is a method, but not one we intend to
    ever call.  This syntax makes that clear to twig, I think.
    remydenton committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    eb3da84 View commit details
    Browse the repository at this point in the history
  4. DS-489: Fix implicitly imported macros

    See https://twig.symfony.com/doc/1.x/deprecated.html#macros
    
    > As of Twig 2.0, macros imported in a file are not available in child
    > templates anymore (via an include call for instance). You need to
    > import macros explicitly in each file where you are using them.
    remydenton committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7e90c66 View commit details
    Browse the repository at this point in the history
  5. DS-547: Restore global data

    The implemented/extended classes here were deprecated well before this
    code was originally written in 2018, in
    #426.
    
    In any case, \Twig\Extension\GlobalsInterface is needed to for the
    getGlobals() method to work now.
    See https://twig.symfony.com/doc/2.x/advanced.html
    remydenton committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9ae7907 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fcab813 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Configuration menu
    Copy the full SHA
    a0dd612 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Configuration menu
    Copy the full SHA
    4316a93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    299a8d3 View commit details
    Browse the repository at this point in the history