-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-489 twig deprecations #2261
Merged
Merged
DS-489 twig deprecations #2261
Commits on Jul 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c593a50 - Browse repository at this point
Copy the full SHA c593a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297fd9f - Browse repository at this point
Copy the full SHA 297fd9fView commit details -
Dot notation does some fancy magic behind the scenes. Read more here: https://twig.symfony.com/doc/2.x/templates.html Something that was added in Twig 2.x, when using foo.bar, it will check for a `hasBar` method on the underlying object if `bar` is not a property of it. In this case, `hasClass` is a method, but not one we intend to ever call. This syntax makes that clear to twig, I think.
Configuration menu - View commit details
-
Copy full SHA for eb3da84 - Browse repository at this point
Copy the full SHA eb3da84View commit details -
DS-489: Fix implicitly imported macros
See https://twig.symfony.com/doc/1.x/deprecated.html#macros > As of Twig 2.0, macros imported in a file are not available in child > templates anymore (via an include call for instance). You need to > import macros explicitly in each file where you are using them.
Configuration menu - View commit details
-
Copy full SHA for 7e90c66 - Browse repository at this point
Copy the full SHA 7e90c66View commit details -
The implemented/extended classes here were deprecated well before this code was originally written in 2018, in #426. In any case, \Twig\Extension\GlobalsInterface is needed to for the getGlobals() method to work now. See https://twig.symfony.com/doc/2.x/advanced.html
Configuration menu - View commit details
-
Copy full SHA for 9ae7907 - Browse repository at this point
Copy the full SHA 9ae7907View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcab813 - Browse repository at this point
Copy the full SHA fcab813View commit details
Commits on Jul 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a0dd612 - Browse repository at this point
Copy the full SHA a0dd612View commit details
Commits on Jul 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4316a93 - Browse repository at this point
Copy the full SHA 4316a93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 299a8d3 - Browse repository at this point
Copy the full SHA 299a8d3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.