DS-558 Deprecate color indigo #2287
Conversation
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/DS-558-deprecate-color-indigo--branch-preview
colbytcook
temporarily deployed
to
feature/DS-558-deprecate-color-indigo--branch-preview
There was a problem hiding this comment.
@MarcinMr We are deprecating not removing. Please roll back some changes.
| 'base': hsl(220.4, 100%, 18.6%), | ||
| 'light': hsl(220.4, 50%, 49%), | ||
| 'xlight': hsl(220.4, 73%, 81%) | ||
| ), | ||
| 'navy': ( |
There was a problem hiding this comment.
We want to deprecate first, make sure Pattern Lab itself doesn't use indigo anymore. We cannot remove yet.
| @@ -95,7 +95,7 @@ | |||
| <bolt-layout template="halves@from-small 33/67@from-medium" padding-top="large" padding-bottom="large" gutter="large" valign-items="center" class="t-bolt-light"> | |||
| <bolt-layout-item valign-self="start-offset"> | |||
| {% include '@bolt-components-image/image.twig' with { | |||
| src: '/images/heros/hero-foreground--indigo.png', | |||
| src: '/images/heros/hero-foreground--navy.png', | |||
There was a problem hiding this comment.
This is a file name, it should not be changed.
| } | ||
| } %} | ||
| {% endif %} | ||
| {% include "_color-swatch.twig" with { |
There was a problem hiding this comment.
Do not remove the condition here. It'll be done when we are removing indigo.
| <bolt-table first-col-fixed-width> | ||
| <table> | ||
| <thead> | ||
| <bolt-text headline font-size="xlarge" tag="h3"> |
There was a problem hiding this comment.
Same here, do not remove the condition.
| {% endfor %} | ||
| </bolt-tab-panel> | ||
|
|
||
| <bolt-tab-panel> | ||
| <bolt-text slot="label">Status Colors</bolt-text> | ||
|
|
||
| {% for color_name, palette in bolt.data.colors.status %} | ||
| {% if color_name != "indigo" %} | ||
| {% if color_name != "navy" %} |
| @@ -13,7 +13,6 @@ | |||
| <bolt-text slot="label">Brand Colors</bolt-text> | |||
|
|
|||
| {% for color_name, palette in bolt.data.colors.brand %} | |||
| {% if color_name != "indigo" %} | |||
| <bolt-text headline font-size="xlarge" tag="h3"> | |||
There was a problem hiding this comment.
Same here, do not remove the condition.
| {% endfor %} | ||
| </bolt-tab-panel> | ||
|
|
||
| <bolt-tab-panel> | ||
| <bolt-text slot="label">Status Colors</bolt-text> | ||
|
|
||
| {% for color_name, palette in bolt.data.colors.status %} | ||
| {% if color_name != "indigo" %} | ||
| {% if color_name != "navy" %} |
| @@ -32,8 +32,8 @@ | |||
| } | |||
| }), | |||
| ]|join(''), | |||
| background: "/images/heros/hero-background--indigo.jpg", | |||
| image: "/images/heros/hero-foreground--indigo.png", | |||
| background: "/images/heros/hero-background--navy.jpg", | |||
There was a problem hiding this comment.
These are file names. Do not change.
| </div> | ||
| </bolt-list-item> | ||
| {% endif %} | ||
| <bolt-list-item> |
There was a problem hiding this comment.
Same here, do not remove the condition.
|
@mikemai2awesome change requests reverted |
There was a problem hiding this comment.
@danielamorse This has some Academy changes, please review.
There was a problem hiding this comment.
I reviewed the Academy changes and made a ticket to update colors in Academy codebase.
@MarcinMr @mikemai2awesome be sure to include a "Release notes" section to your PR description when there are deprecations. See this PR for reference 🙏
|
@danielamorse I added release notes to this PR, let me know if that's ok. |
There was a problem hiding this comment.
Thanks for updating the "Release notes" @MarcinMr. I just removed the "Deprecations" heading.
We don't have an official format for this, but here's how the notes get compiled for an actual release. Maybe in a future dev huddle we can decide on a good format and document it.
Jira
https://pegadigitalit.atlassian.net/browse/DS-558
Summary
Any
indigousage was converted tonavy.How to test
Make sure there is no more colour
indigopresent in the repo.Release notes
The
indigocolour has been renamed tonavy.