DS-599: Optimized Campaign Landing Page #2310

colbytcook · 2021-09-03T17:27:28Z

Jira

https://pegadigitalit.atlassian.net/browse/DS-599

Summary

Created the demo pages for the Optimized Campaign Landing Page

Details

Created doc pages for the Optimized Campaign Landing Page templates
Create doc pages for the Optimized Campaign Landing Page themes
Modified the Layout CSS to fix a mobile bug
Text + Icon spacing adjusted in Button and Text Link elements (due to Icon element handling white space better than Icon component)

How to test

Pull down the branch and look at the Optimized Campaign Landing Page templates in the doc site
Reveal the Patternlab test folder and look at the examples of the themes
Check for regressions on the Layout Component (this PR modifies the Layout Item width behavior so we need some deep checks here).
Review the Video Thumbnail Center Component (we can change the name if we need) docs

Release notes

Added the Optimized Campaign Landing Page docs pages

Visual Changes

Button Element

Slightly increased the gap between button text and icon

Text Link Element

Slightly increased the gap between link text and icon

… icon to the Icon Element

…gnsystem/bolt into feature/DS-599-campaign-landing

…anding page templates, added a JS snippet to close the model on desktop

…p bug

…ed the OCLP Video page with a Preview button

colbytcook · 2021-09-03T17:30:17Z

@mikemai2awesome I will like some feedback on the layout.scss change that was made. Adding the minmax function here solves the carousel width issues we were having with the layout-item. I have done testing on and it seems that it did not introduce any regressions but I would like to get other eyes on this.

colbytcook · 2021-09-03T17:33:28Z

TODO: We need to solve the "Theme 4" and "Theme 6" image placements. It seems that these one are not rendering correctly on the template due to their image orientation (these are vertical while the remaining four are horizontal). We might need to re-export these assets to change their orientation.

… the desktop form

mikemai2awesome · 2021-09-07T22:22:56Z

@colbytcook Thank you for jumping on this. I'll review what you did. I don't think we need to change any assets, they are positioned with specific css in specific layouts.

mikemai2awesome

Waiting for #2313 (review) to get the Video Thumbnail updates.

mikemai2awesome

I pulled in the Video Thumbnail updates. This is all set.

danielamorse

This looks good guys! Tested new templates and Bolt Layout (no regressions found).

I added the Button and Link Text icon spacing changes to the Release Notes. Important to flag this type of change for QA.

danielamorse · 2021-09-10T13:40:06Z

packages/layouts/bolt-layout/src/layout-item.twig

@@ -8,7 +8,7 @@
 {% set item_attributes = create_attribute(attributes|default({})) %}

 <bolt-layout-item
-  {{ source_order ? 'source-order="' ~ source_order ~ '"' : '' }}


Does this fix a bug? It looks like the name didn't match the schema before. If it fixes a Layout bug, let's note it in the Release Notes.

Seems like it would fix a bug... we're using the <bolt-layout> custom element in the layout authoring work, because twig wasn't working (I don't know the details). Maybe this was the problem, or part of it?

Yes this was a fix to a bug in the ordering, there was a discrepancy between the schema and the twig (exactly what you said Dan).

remydenton

Broadly speaking, the code looks good. We plan to review these with stakeholders, right?

bolt-bot and others added 12 commits August 24, 2021 15:33

Initial creation of the OCLP template

a6b4c0a

DS-599: Worked on the patternlab pages

0b75c96

ds-599: set up gated page layout

b9a8708

ds-599: style footer and fix SVGs

282fc19

ds-599: create ungated pages

346147b

Merge branch 'master' into feature/DS-599-campaign-landing

985dd2a

Updated with the latest from upstream and added the pega-download-pdf…

b1e2869

… icon to the Icon Element

Merge branch 'feature/DS-599-campaign-landing' of github.com:boltdesi…

e7ac5f3

…gnsystem/bolt into feature/DS-599-campaign-landing

Updated the layout.scss to fix a mobile alignment bug, reworked the l…

517336b

…anding page templates, added a JS snippet to close the model on desktop

Cleaned up the video and image templates and fixed a layout order pro…

d1f69ed

…p bug

Added a center_component prop to the video thumbnail component, updat…

ea9fa21

…ed the OCLP Video page with a Preview button

Created the OCLP theme doc tets pages

3add3d8

colbytcook requested review from danielamorse, remydenton, mikemai2awesome, cjwhitedev and MarcinMr September 3, 2021 17:27

github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Sep 3, 2021

colbytcook requested a deployment to feature/DS-599-campaign-landing--3add3d80--commit-preview September 3, 2021 17:48 Abandoned

Tweaked the OCLP background themes and added in a sticky behavior for…

217bacd

… the desktop form

colbytcook requested a deployment to feature/ds-459-new-modal--8df729dc--commit-preview September 7, 2021 12:27 In progress

colbytcook changed the title ~~[DO NOT MERGE] DS-599: Optimized Campaign Landing Page~~ DS-599: Optimized Campaign Landing Page Sep 8, 2021

mikemai2awesome added 2 commits September 8, 2021 14:44

Merge branch 'master' into feature/DS-599-campaign-landing

9ce8693

ds-599: fix button and link icon spacing and update demos

d38dcd6

colbytcook requested a deployment to feature/DS-599-campaign-landing--d38dcd6b--commit-preview September 8, 2021 22:57 In progress

ds-599: fix footer text align

86bb3f2

colbytcook deployed to feature/DS-599-campaign-landing--86bb3f2d--commit-preview September 9, 2021 14:02 View deployment

colbytcook temporarily deployed to feature/DS-599-campaign-landing--branch-preview September 9, 2021 14:07 Inactive

ds-599: refine demos

fd3a6d4

colbytcook deployed to feature/DS-599-campaign-landing--fd3a6d46--commit-preview September 9, 2021 18:34 View deployment

colbytcook temporarily deployed to feature/DS-599-campaign-landing--branch-preview September 9, 2021 18:38 Inactive

mikemai2awesome added 2 commits September 9, 2021 15:13

ds-599: code cleanup and revert video thumbnail changes

9974c5e

ds-599: revert another video thumbnail change

02168dc

colbytcook deployed to feature/DS-599-campaign-landing--02168dcf--commit-preview September 9, 2021 20:04 View deployment

colbytcook temporarily deployed to feature/DS-599-campaign-landing--branch-preview September 9, 2021 20:09 Inactive

mikemai2awesome requested changes Sep 9, 2021

View reviewed changes

mikemai2awesome added 2 commits September 9, 2021 16:36

ds-599: remove old pages

4d7421d

ds-599: fix test pages

5306ec2

colbytcook deployed to feature/DS-599-campaign-landing--4d7421dd--commit-preview September 9, 2021 21:10 View deployment

ds-599: fix gutter on a demo page

cb745a4

colbytcook requested a deployment to feature/www-920-video-thumbnail-chip-and-title--00cd9b0f--commit-preview September 9, 2021 21:14 In progress

colbytcook deployed to feature/DS-599-campaign-landing--cb745a46--commit-preview September 9, 2021 22:09 View deployment

colbytcook temporarily deployed to feature/DS-599-campaign-landing--branch-preview September 9, 2021 22:13 Inactive

mikemai2awesome added 2 commits September 10, 2021 08:07

Merge branch 'master' into feature/DS-599-campaign-landing

6979020

ds-599: add preview video thumbnail

2ac0d92

mikemai2awesome approved these changes Sep 10, 2021

View reviewed changes

colbytcook deployed to feature/DS-599-campaign-landing--2ac0d928--commit-preview September 10, 2021 12:46 View deployment

colbytcook had a problem deploying to feature/DS-599-campaign-landing--branch-preview September 10, 2021 12:50 Failure

danielamorse approved these changes Sep 10, 2021

View reviewed changes

Updated the video modal with the 'data-video-delayed' prop

ed57341

colbytcook deployed to feature/DS-599-campaign-landing--branch-preview September 10, 2021 15:07 View deployment

colbytcook requested a deployment to feature/DS-599-campaign-landing--branch-preview September 10, 2021 15:11 Abandoned

remydenton approved these changes Sep 10, 2021

View reviewed changes

colbytcook merged commit cb147b7 into master Sep 10, 2021

colbytcook deleted the feature/DS-599-campaign-landing branch September 10, 2021 21:33

MarcinMr mentioned this pull request Sep 13, 2021

DS-529: Pega.com: Add 'Download slides' CTA to PW Replays "Best Of" cards #2312

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DS-599: Optimized Campaign Landing Page #2310

DS-599: Optimized Campaign Landing Page #2310

colbytcook commented Sep 3, 2021 •

edited by danielamorse

Loading

colbytcook commented Sep 3, 2021

colbytcook commented Sep 3, 2021 •

edited

Loading

mikemai2awesome commented Sep 7, 2021

mikemai2awesome left a comment

mikemai2awesome left a comment

danielamorse left a comment

danielamorse Sep 10, 2021

remydenton Sep 10, 2021

colbytcook Sep 10, 2021

remydenton left a comment

DS-599: Optimized Campaign Landing Page #2310

DS-599: Optimized Campaign Landing Page #2310

Conversation

colbytcook commented Sep 3, 2021 • edited by danielamorse Loading

Jira

Summary

Details

How to test

Release notes

Visual Changes

Button Element

Text Link Element

colbytcook commented Sep 3, 2021

colbytcook commented Sep 3, 2021 • edited Loading

mikemai2awesome commented Sep 7, 2021

mikemai2awesome left a comment

Choose a reason for hiding this comment

mikemai2awesome left a comment

Choose a reason for hiding this comment

danielamorse left a comment

Choose a reason for hiding this comment

danielamorse Sep 10, 2021

Choose a reason for hiding this comment

remydenton Sep 10, 2021

Choose a reason for hiding this comment

colbytcook Sep 10, 2021

Choose a reason for hiding this comment

remydenton left a comment

Choose a reason for hiding this comment

colbytcook commented Sep 3, 2021 •

edited by danielamorse

Loading

colbytcook commented Sep 3, 2021 •

edited

Loading