Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-610: Remove fill attribute from all twig versions of icons #2315

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

adamszalapski
Copy link
Collaborator

@adamszalapski adamszalapski commented Sep 10, 2021

Jira

https://pegadigitalit.atlassian.net/browse/DS-610

Summary

Fill prop was removed from the twig version of icons.

Details

Fill prop was removed from the twig version of icons.

How to test

Run this code locally and check if all icons are rendered correctly.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Sep 10, 2021
@colbytcook colbytcook temporarily deployed to feature/DS-610--branch-preview September 10, 2021 13:28 Inactive
Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be working.

@colbytcook colbytcook changed the title Remove fill attribute from all twig versions of icons DS-610: Remove fill attribute from all twig versions of icons Sep 13, 2021
@colbytcook colbytcook merged commit a03fe5f into master Sep 13, 2021
@colbytcook colbytcook deleted the feature/DS-610 branch September 13, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants