COM-707 Raise signifier link above headline link #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
colbytcook
requested a deployment
to
feature/DS-594-replace-icons-in-components--cf893029--commit-preview
colbytcook
temporarily deployed
to
bugfix/com-707-listing-teaser-signifier-link--branch-preview
mikemai2awesome
changed the title
colbytcook
had a problem deploying
to
bugfix/com-707-listing-teaser-signifier-link--2f9b970d--commit-preview
colbytcook
temporarily deployed
to
bugfix/com-707-listing-teaser-signifier-link--branch-preview
colbytcook
requested changes
Sep 29, 2021
colbytcook
temporarily deployed
to
bugfix/com-707-listing-teaser-signifier-link--branch-preview
|
@mikemai2awesome Looks good! I am seeing the fix on the Listing Teaser Search (/pattern-lab/?p=components-listing-teaser-use-case-search-result-list) page but I am not Community Search Page (/pattern-lab/?p=pages-community-search-layout). Not sure if that matters or not but I figured I would call it out. |
|
@colbytcook Good catch. This should do it. |
colbytcook
approved these changes
Oct 4, 2021
danielamorse
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/COM-707
Summary
Updates the Listing Teaser to allow signifier link to have a higher stacking order than the main headline link.
Details
How to test
Run the branch locally and view docs under Listing Teaser. In the Search Results demo page, go to the Related Videos section, the video thumbnail should open a video modal, the headline link should lead to a page.