DS-821 WWW: Button Icon Size Bug #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-821
Summary
Font size variable
--e-bolt-button-font-sizeis adapted to the helper button class ->.e-bolt-button--*SIZE*Details
.e-bolt-button--smallhas small font size (--e-bolt-button-font-size: var(--bolt-type-font-size-small)).e-bolt-button--xsmallhas xsmall font size (--e-bolt-button-font-size: var(--bolt-type-font-size-xsmall))--e-bolt-button-icon-only-size: 1.1emboth in the case of.e-bolt-button--smalland.e-bolt-button--xsmallHow to test
Pull the branch.
Go to
/pattern-lab/?p=elements-button-size.👉 Check if the small button and the xsmall button have appropriate sizes of the font. The small button should have a small font-size and the xsmall button should have xsmall font-size.
Go to
/pattern-lab/?p=elements-button-with-icon-only👉 If you add to the only-icon button a helper class
.e-bolt-button--smallor.e-bolt-button--xsmallboth cases should have the same--e-bolt-button-icon-only-size: 1.1emVisual changes
Buttons xsmall and small have adjusted font-size variables (small button - small font size, xsmall button - xsmall font size)