Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/update guides #954

Merged
merged 5 commits into from
Nov 18, 2018
Merged

Task/update guides #954

merged 5 commits into from
Nov 18, 2018

Conversation

danielamorse
Copy link
Collaborator

@danielamorse danielamorse commented Nov 14, 2018

Jira

n/a

Summary

Edit the guides to setting up Bolt locally.

Details

  • Changed curly quotes to straight quotes to avoid copy-paste issues in terminal
  • Removed deprecated 'homebrew-php' package, which has been migrated into 'homebrew-core'
  • Added comment after PHP installation which ensures terminal is referencing the right version of PHP

How to test

@bolt-bot
Copy link
Collaborator

⚡ PR built on Travis and deployed a now preview here:

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thanks @danielamorse!

@sghoweri sghoweri changed the base branch from master to release/2.x November 16, 2018 20:47
@sghoweri sghoweri merged commit fead0b1 into release/2.x Nov 18, 2018
@sghoweri sghoweri deleted the task/update-guides branch November 18, 2018 13:35
@sghoweri sghoweri mentioned this pull request Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants