Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error installing: does not contain packages matching github.com/bombsimon/wsl/v4/cmd/... #127

Closed
MichaelSnowden opened this issue Mar 29, 2023 · 5 comments

Comments

@MichaelSnowden
Copy link
Contributor

I'm not able to install this package. Here's the steps to repo:

$ cd $(mktemp -d)          
$ go version
go version go1.19.2 darwin/arm64
$ go mod init example.com/m
go: creating new go.mod: module example.com/m
$ go get github.com/bombsimon/wsl/v4/cmd/...

go: module github.com/bombsimon/wsl@upgrade found (v1.2.8), but does not contain packages matching github.com/bombsimon/wsl/v4/cmd/...
$
@bombsimon
Copy link
Owner

Oh, I didn't know this. I wonder if this is since v4.0.0 tag is pre-release.

go list -m -versions github.com/bombsimon/wsl
github.com/bombsimon/wsl v1.0.0 v1.0.1 v1.1.0 v1.2.0 v1.2.1 v1.2.2 v1.2.3 v1.2.4 v1.2.5 v1.2.6 v1.2.7 v1.2.8-issue-60 v1.2.8

go list -m -versions github.com/bombsimon/wsl/v3
github.com/bombsimon/wsl/v3 v3.0.0 v3.1.0 v3.2.0 v3.3.0 v3.4.0

go list -m -versions github.com/bombsimon/wsl/v4
github.com/bombsimon/wsl/v4

It also seems like that's a typo, it should be go install so it doesn't add it to go mod. Let me update the readme and create a new release to see if that fixes the problem.

@bombsimon
Copy link
Owner

Actually for now I want to clean up the interface and how to create the analyzer before making a non pre-release. I think the v4.0.0 tag was a bit premature already. I'll update the README once I draft a final release but for now would you mind installing from master? This should do the trick:

go install github.com/bombsimon/wsl/v4/cmd...@master

@MichaelSnowden
Copy link
Contributor Author

Actually for now I want to clean up the interface and how to create the analyzer before making a non pre-release. I think the v4.0.0 tag was a bit premature already. I'll update the README once I draft a final release but for now would you mind installing from master? This should do the trick:

go install github.com/bombsimon/wsl/v4/cmd...@master

That worked, thanks!

@bombsimon
Copy link
Owner

Awesome!

Also realized this has nothing to do with GH releases (of course 🤦), it's because the commit for the tag v4.0.0 has v3 in go.mod so that tag and release is broken and useless.

I'll keep this issue open so I remember to create a new proper release and update the docs asap.

@bombsimon
Copy link
Owner

Since I didn't update anything yet and got a new issue for this I just updated the readme with the above command instead. Closing this but aim to finalize the API and bump golangci-lint at some point soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants