Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to note that yore 0.3.x is not compatible with Rust 1.71.0 #6

Closed
theCapypara opened this issue Jul 24, 2023 · 2 comments

Comments

@theCapypara
Copy link

theCapypara commented Jul 24, 2023

It seems that this commit e7f620f not only improved performance but also fixed some issue that prevents yore from running with Rust 1.71.0.

If I try to run yore 0.3.x with Rust 1.71.0 with Strings with multiple graphemes, it breaks.

use yore::code_pages::CP850;

fn main() {
    let before = CP850.encode_lossy("ß123äöü", 0x20);
    let after = CP850.decode(&before);
    dbg!(&before);
    dbg!(after);
}

Actual output:

[src/main.rs:6] &before = [
    225,
    49,
    50,
    51,
    132,
    148,
    129,
]
[src/main.rs:7] after = "\u{2}\u{1}\u{1}\u{2}thread 'main' panicked at 'byte index 12 is out of bounds of ``', library/core/src/fmt/mod.rs:2324:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected output:

[src/main.rs:6] &before = [
    225,
    49,
    50,
    51,
    132,
    148,
    129,
]
[src/main.rs:7] after = "ß123äöü"

There isn't really anything to do, since it works perfectly with 1.0, but I want to suggest maybe just adding a little note to the README about this.

@bonega
Copy link
Owner

bonega commented Jul 26, 2023

Hey, thanks for creating the issue.
I have released a new version that contains a note about it in the changelog

@theCapypara
Copy link
Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants