You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that this commit e7f620f not only improved performance but also fixed some issue that prevents yore from running with Rust 1.71.0.
If I try to run yore 0.3.x with Rust 1.71.0 with Strings with multiple graphemes, it breaks.
use yore::code_pages::CP850;fnmain(){let before = CP850.encode_lossy("ß123äöü",0x20);let after = CP850.decode(&before);dbg!(&before);dbg!(after);}
Actual output:
[src/main.rs:6] &before = [
225,
49,
50,
51,
132,
148,
129,
]
[src/main.rs:7] after = "\u{2}\u{1}\u{1}\u{2}thread 'main' panicked at 'byte index 12 is out of bounds of ``', library/core/src/fmt/mod.rs:2324:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
It seems that this commit e7f620f not only improved performance but also fixed some issue that prevents yore from running with Rust 1.71.0.
If I try to run yore 0.3.x with Rust 1.71.0 with Strings with multiple graphemes, it breaks.
Actual output:
Expected output:
There isn't really anything to do, since it works perfectly with 1.0, but I want to suggest maybe just adding a little note to the README about this.
The text was updated successfully, but these errors were encountered: