Zipper CarbonV2 gRPC render stream #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadolsky
force-pushed
the
emadolsky/zipper-render-stream
branch
2 times, most recently
from
4e19da3
to
e4a6a8c
Compare
emadolsky
force-pushed
the
emadolsky/zipper-render-stream
branch
from
e4a6a8c
to
0b22237
Compare
emadolsky
changed the title
bom-d-van
reviewed
Jul 13, 2022
bom-d-van
reviewed
Jul 13, 2022
bom-d-van
reviewed
Jul 13, 2022
bom-d-van
reviewed
Jul 19, 2022
| protocolBackends: | ||
| - http: "http://10.291.202.31:8080" | ||
| - http: "http://10.291.197.91:8080" | ||
| grpc: "10.291.197.91:7070" |
There was a problem hiding this comment.
it's minor, but you can simplify things by:
protocolBackends:
- "http://10.291.202.31:8080"
- "http://10.291.197.91:8080"
"grpc://10.291.197.91:7070"
net/url pkg actually supports parsing it: https://pkg.go.dev/net/url@go1.18.4#Parse
There was a problem hiding this comment.
I have difficulty understanding the structure of protocolBackend. Do you mean it can be simplified to list of strings? In that case it would be like:
protocolBackends:
- ["http://10.291.202.31:8080"]
- ["http://10.291.197.91:8080",
"grpc://10.291.197.91:7070"]
Which is not desired IMO. However, after implementing gRPC for all of the calls, it can be simplified to one string in which url scheme determines the backend type. E.g.
protocolBackends:
- "http://10.291.202.31:8080"
- "grpc://10.291.197.91:7070"
There was a problem hiding this comment.
oops, sorry, the example that I gave wasn't correct, I wanted to suggest an array of array:
protocolBackends:
- "http://10.291.202.31:8080"
- - "http://10.291.197.91:8080"
- "grpc://10.291.197.91:7070"
bom-d-van
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of gRPC streaming Renders in carbonzipper. The new gRPC protocol is proposed at go-graphite/protocol#12, and storage part is implemented on go-graphite/go-carbon#476.
Outline:
A new backend configuration structure is proposed as
ProtocolBackendwhich defines different protocol addresses of a backend. The change is backward compatible.The current implementation only uses gRPC for Renders as we have not implemented other APIs here or in go-carbon. For the other APIs such as Find, old methods are used.
The changes are tested manually in container environment.
Some works should be done before merging: