Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CarbonV2 gRPC streaming render #476

Merged
merged 12 commits into from Jul 18, 2022
Merged

CarbonV2 gRPC streaming render #476

merged 12 commits into from Jul 18, 2022

Conversation

emadolsky
Copy link
Contributor

This PR

  • adds gRPC listener to carbonserver
  • brings CarbonV2 gRPC services into play
  • implements streaming gRPC Render functionality

This is manually tested in container environment.

Notes:

@emadolsky emadolsky mentioned this pull request Jul 4, 2022
Merged
1 task
@emadolsky emadolsky force-pushed the emadolsky/grpc-streaming-render branch from c22e4f4 to 1accaf4 Compare July 13, 2022 13:05
@emadolsky emadolsky changed the title Emadolsky/grpc streaming render CarbonV2 gRPC streaming render Jul 13, 2022
bom-d-van
bom-d-van reviewed Jul 13, 2022
View reviewed changes
carbonserver/render.go Outdated Show resolved Hide resolved
@bom-d-van
Copy link
Member

there are a few deep source check errors, can you check try resolving it or silence it with // skipcq: comment? tx.

@emadolsky emadolsky force-pushed the emadolsky/grpc-streaming-render branch from e2c9162 to 504d7ad Compare July 15, 2022 11:55
@bom-d-van
Copy link
Member

after you mark this pr as ready for review, I guess I can approve it.

just a simple recap and being a paranoid in case I missed it, no backward-incompatibilities are expected, right?

@emadolsky
Copy link
Contributor Author

emadolsky commented Jul 18, 2022 •
edited

after you mark this pr as ready for review, I guess I can approve it.

Excellent! I will mark it as ready for review as soon as go-graphite/protocol#12 is merged and the lib ref here is updated. Can you check that out as well?

just a simple recap and being a paranoid in case I missed it, no backward-incompatibilities are expected, right?

That's right. The old proto messages stay the same (new messages and service are added), old API works in the same way as before alongside with the new gRPC implementation.

@bom-d-van
Copy link
Member

Excellent! I will mark it as ready for review as soon as go-graphite/protocol#12 is merged and the lib ref here is updated. Can you check that out as well?

I have approved the protocol pr. let's give Vladimir a few hours to see if he has opinions there.

@emadolsky emadolsky marked this pull request as ready for review July 18, 2022 13:57
@emadolsky emadolsky requested a review from bom-d-van July 18, 2022 13:57
@emadolsky emadolsky merged commit cc8eeda into master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bom-d-van bom-d-van bom-d-van approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emadolsky @bom-d-van