Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug on aac.c #11

Closed
libTorrentUser opened this issue May 17, 2019 · 2 comments
Closed

bug on aac.c #11

libTorrentUser opened this issue May 17, 2019 · 2 comments

Comments

@libTorrentUser
Copy link

There is a bug on aac.c, line 187

NeAACDecHandle h=NeAACDecOpen();

in order to fix it, just chang it to

h=NeAACDecOpen();

it is the reason a lot of people is complaining about crashes, seg-fault, etc. Quite silly once you find it. I bet someone ctrl+c, ctrl+v that part of the code, isn't that right, bookkojot?
:)

@bookkojot
Copy link
Owner

Maybe, it was soo loooon agooooo...
Thanks, for fix!

@libTorrentUser
Copy link
Author

I should be the one thanking you. I was trying to recover a broken mp4 file, and although I was able to recover the video (doing pretty much the same thing you did), I was having no luck with the audio. Then I saw your code and tried your idea of converting AAC audio from the "working" file to adts and use its header on the audio data extracted from the broken file + faad to generate a fixed ACC stream in adts.

So, thank YOU :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants