New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second argument of model destroyed event #1777

Merged
merged 1 commit into from Mar 3, 2018

Conversation

Projects
1 participant
@ricardograca
Member

ricardograca commented Mar 3, 2018

Introduction

In #1723 it was discovered that the second argument to the destroyed event was completely useless, so this just removes it.

Motivation

There is no point in having that argument as it will always have the same value. See the above linked related issue for more info.

Fixes #1722.

Current PR Issues

This is a breaking change in case someone is using the current third argument (options) for something in this event's handler. This is highly unlikely, so the disruption should be minimal or non-existent.

@ricardograca ricardograca added this to To Do in Version 0.13.0 via automation Mar 3, 2018

@ricardograca ricardograca added the docs label Mar 3, 2018

@ricardograca ricardograca moved this from To Do to In Progress in Version 0.13.0 Mar 3, 2018

@ricardograca ricardograca merged commit eb80195 into master Mar 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Version 0.13.0 automation moved this from In Progress to Done Mar 3, 2018

@ricardograca ricardograca deleted the rg-destroyed-event branch Mar 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment