Links should not be converted to corner-bracket format when sending HTML email #220
Milestone
Comments
boonebgorges
added a commit
that referenced
this issue
Jun 6, 2023
…mails. We still do it in non-HTML emails, using the `ass_email_convert_html_to_plaintext()` tool. In the case of plaintext fallback for HTML emails, the aforementioned function already does the necessary conversion. See #220.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When BPGES was first developed, BP emails were sent in plaintext. This meant that BPGES was forced to strip HTML tags from activity content. In the case of links, simple
strip_tags()resulted in a loss of information, since thehrefattribute would go missing. So we introduced theass_convert_links()utility, which took items of the form<a href="https://google.com">Google</a>toGoogle <https://google.com>.This worked well for plaintext formatted emails. But when email is sent in HTML format, it causes problems in some clients, which interpret
<https://google.com>as an invalid tag, and strip it from the content.ass_convert_links()should only be applied when HTML email is disabled, or when generating the plaintext fallback.The text was updated successfully, but these errors were encountered: