Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from City Tech OpenLab: Changes to email notifications #394

Closed
bree-z opened this issue May 12, 2022 · 6 comments
Closed

Port from City Tech OpenLab: Changes to email notifications #394

bree-z opened this issue May 12, 2022 · 6 comments
Assignees
Labels
Needs testing OpenLab Issues specifically related to the OpenLab package
Milestone

Comments

@bree-z
Copy link

bree-z commented May 12, 2022

Hi Boone,

Can we port the changes we're making to email notifications to CBOX OpenLab?

Thanks!

@bree-z bree-z added the OpenLab Issues specifically related to the OpenLab package label May 12, 2022
@bree-z bree-z added this to the 1.4.0 milestone May 12, 2022
@boonebgorges
Copy link
Member

We're still some way from deciding what will happen on the OpenLab for 3028. We'll need to build it there before we can decide whether it's easy and/or wise to include in CBOX.

For 3025, the OpenLab-specific fix is not very good, and not appropriate for CBOX. Ideally we'd fix the problem in BPGES boonebgorges/buddypress-group-email-subscription#220, and our ability to do so will depend on summer funding. Let's hold off for a few weeks while this shakes out.

@boonebgorges boonebgorges modified the milestones: 1.4.0, 1.5.0 Jan 9, 2023
@boonebgorges
Copy link
Member

Item 2 should be addressed by boonebgorges/buddypress-group-email-subscription#220. I've patched openlabdev.commonsinabox.org with this fix for the purposes of testing.

@boonebgorges
Copy link
Member

For item 1, I've added openlab-email-embedded-media as a required plugin for the OpenLab package.

I've set this up to test on openlabdev.commonsinabox.org. However, I can't get any emails to be sent by that site at the moment. @bree-z When you start testing, perhaps you could see if this is a problem specific to my account. If outgoing email is busted, I may instead need to switch to an SMTP sender for that site so that we can test features like this.

@bree-z
Copy link
Author

bree-z commented Jul 12, 2023

I'm getting email notifications on openlabdev.commonsinabox.org, but I don't see any media embeds or links in those notifications.

When I check in https://openlabdev.commonsinabox.org/wp-admin/network/admin.php?page=cbox-plugins I see that 'Email Embedded Media' is active.

See screenshots below of the email notifications for these two posts:

https://openlabdev.commonsinabox.org/omnia-peccata-paria-dicitis/2023/07/12/testing-media/
https://openlabdev.commonsinabox.org/omnia-peccata-paria-dicitis/2023/07/12/links/

PostWithMedia PostWithLinks

boonebgorges added a commit to cuny-academic-commons/cbox-openlab-core that referenced this issue Jul 12, 2023
@boonebgorges
Copy link
Member

There were some additional changes that had happened on the OpenLab since the CBOX-OL fork that needed to be applied here - namely, the OL uses the full text of the blog post when generating a BPGES email, but CBOX-OL never did that. As a result, the BPGES notification was being generated from the BP activity stream item, which is stripped of all HTML tags. This problem should now be fixed.

@bree-z
Copy link
Author

bree-z commented Jul 12, 2023

Thanks Boone! This looks good.

@bree-z bree-z closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing OpenLab Issues specifically related to the OpenLab package
Projects
None yet
Development

No branches or pull requests

2 participants