-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port from City Tech OpenLab: Changes to email notifications #394
Comments
We're still some way from deciding what will happen on the OpenLab for 3028. We'll need to build it there before we can decide whether it's easy and/or wise to include in CBOX. For 3025, the OpenLab-specific fix is not very good, and not appropriate for CBOX. Ideally we'd fix the problem in BPGES boonebgorges/buddypress-group-email-subscription#220, and our ability to do so will depend on summer funding. Let's hold off for a few weeks while this shakes out. |
Item 2 should be addressed by boonebgorges/buddypress-group-email-subscription#220. I've patched openlabdev.commonsinabox.org with this fix for the purposes of testing. |
For item 1, I've added openlab-email-embedded-media as a required plugin for the OpenLab package. I've set this up to test on openlabdev.commonsinabox.org. However, I can't get any emails to be sent by that site at the moment. @bree-z When you start testing, perhaps you could see if this is a problem specific to my account. If outgoing email is busted, I may instead need to switch to an SMTP sender for that site so that we can test features like this. |
I'm getting email notifications on openlabdev.commonsinabox.org, but I don't see any media embeds or links in those notifications. When I check in https://openlabdev.commonsinabox.org/wp-admin/network/admin.php?page=cbox-plugins I see that 'Email Embedded Media' is active. See screenshots below of the email notifications for these two posts: https://openlabdev.commonsinabox.org/omnia-peccata-paria-dicitis/2023/07/12/testing-media/ ![]() ![]() |
There were some additional changes that had happened on the OpenLab since the CBOX-OL fork that needed to be applied here - namely, the OL uses the full text of the blog post when generating a BPGES email, but CBOX-OL never did that. As a result, the BPGES notification was being generated from the BP activity stream item, which is stripped of all HTML tags. This problem should now be fixed. |
Thanks Boone! This looks good. |
Hi Boone,
Can we port the changes we're making to email notifications to CBOX OpenLab?
Thanks!
The text was updated successfully, but these errors were encountered: