Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved filters for activity action strings #224

Closed
boonebgorges opened this issue Jul 12, 2022 · 1 comment
Closed

Improved filters for activity action strings #224

boonebgorges opened this issue Jul 12, 2022 · 1 comment
Milestone
4.0.2

Comments

@boonebgorges
Copy link
Owner

BP doesn't have a single centralized place to filter action strings like 'Jane commented on the post Foo'. We should have filters in BPGES so that this text can be filtered in the context of BPGES emails (for both the email content and the subject line). These filters should include information about the activity item, which the ass_clean_subject filter does not.
@boonebgorges boonebgorges added this to the 4.0.2 milestone Jul 12, 2022
boonebgorges added a commit that referenced this issue Jul 12, 2022
@boonebgorges
Introduce bpges_activity_action filter and use when generating single…
ea347c0 
… notifications.

We also ensure that the filtered `$action` variable is used when building
the subject line and when passing tokens to `ass_send_email()`.

See #224.
@boonebgorges
Copy link
Owner Author

Closing because 4.0.2 is already released.

@boonebgorges boonebgorges mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.2
Development

No branches or pull requests
1 participant
@boonebgorges