Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip HTML links from activity action when used in email content #226

Closed
boonebgorges opened this issue Nov 2, 2022 · 0 comments
Closed
Milestone

Comments

@boonebgorges
Copy link
Owner

Previously: #224

Currently, the same sanitized version of $activity->action is used both to generate the email subject and in the intro of the email content. In both cases, we strip HTML. But, since BPGES started defaulting to the rich-text BP email system several versions ago, this means that we get a lower-fidelity email than we should.

In order to make this work, we'll have to pass the action through two different sets of filters.

@boonebgorges boonebgorges added this to the 4.1.0 milestone Nov 2, 2022
boonebgorges added a commit that referenced this issue Nov 2, 2022
… content.

HTML tags are no longer stripped from the action string when used
in the content of an email.

Two new filters are introduced: `bpges_notification_subject` and
`bpges_notification_activity_action`

Fixes #226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant