Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call allocator_traits<T>::construct #1332

Closed
vinniefalco opened this issue Dec 2, 2018 · 1 comment
Closed

Don't call allocator_traits<T>::construct #1332

vinniefalco opened this issue Dec 2, 2018 · 1 comment
Labels
Optimization

Comments

@vinniefalco
Copy link
Member

construct should only be used by containers to construct a user-supplied value_type. I don't think there are any places in Beast that this is applicable to, so all current calls to construct should be replaced with ordinary construction.
@stale
Copy link

stale bot commented Jan 1, 2019

This issue has been open for a while with no activity, has it been resolved?

@stale stale bot added the Stale No recent activity label Jan 1, 2019
@stale stale bot removed the Stale No recent activity label Jan 1, 2019
djarek added a commit to djarek/beast that referenced this issue May 19, 2019
@djarek
Don't call allocator_traits<T>::construct unnecessarily:
2577c51 
It should only be called when constructing a user-provided type.

Close boostorg#1332

Signed-off-by: Damian Jarek <damian.jarek93@gmail.com>
djarek added a commit to djarek/beast that referenced this issue May 19, 2019
@djarek
Don't call allocator_traits<T>::construct unnecessarily:
3df585b 
It should only be called when constructing a user-provided type.

Close boostorg#1332

Signed-off-by: Damian Jarek <damian.jarek93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vinniefalco