Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify openssl on windows #2017

Closed
wants to merge 1 commit into from
Closed

Conversation

sdarwin
Copy link
Contributor

@sdarwin sdarwin commented Jul 14, 2020

For your consideration.
I don't believe this creates any new requirement on OpenSSL which wasn't there before. The goal is only to make including the libraries easier. Let me know what you think.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at http://2017.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #2017 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2017      +/-   ##
===========================================
- Coverage    95.09%   95.08%   -0.01%     
===========================================
  Files          153      153              
  Lines        11939    11939              
===========================================
- Hits         11353    11352       -1     
- Misses         586      587       +1     
Impacted Files Coverage Δ
include/boost/beast/websocket/impl/ping.hpp 96.42% <0.00%> (-0.90%) ⬇️
include/boost/beast/zlib/detail/deflate_stream.ipp 88.50% <0.00%> (-0.11%) ⬇️
include/boost/beast/zlib/detail/inflate_stream.ipp 94.57% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3486e9c...7749843. Read the comment docs.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at http://2017.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

Copy link
Collaborator

@madmongo1 madmongo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Approved.

madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 17, 2020
@vinniefalco
Copy link
Member

Don't need punctuation in the first line of commit messages

madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 20, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 20, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 22, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 22, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 22, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 24, 2020
@madmongo1 madmongo1 closed this in 201105e Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants