Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebSocket examples to set TLS SNI #2019

Closed
wants to merge 1 commit into from

Conversation

madmongo1
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #2019 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2019   +/-   ##
========================================
  Coverage    95.09%   95.09%           
========================================
  Files          153      153           
  Lines        11939    11939           
========================================
  Hits         11353    11353           
  Misses         586      586           
Impacted Files Coverage Δ
include/boost/beast/websocket/impl/ping.hpp 96.42% <0.00%> (-0.90%) ⬇️
include/boost/beast/zlib/detail/inflate_stream.ipp 94.57% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3486e9c...ee782d4. Read the comment docs.

madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 17, 2020
ws_.next_layer().native_handle(),
host_.c_str()))
{
ec = beast::error_code(static_cast<int>(::ERR_get_error()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all the examples which call SSL_set_tlsext_host_name also call ::ERR_get_error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 20, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 20, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 22, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 22, 2020
madmongo1 added a commit to madmongo1/beast that referenced this pull request Jul 22, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This issue has been open for a while with no activity, has it been resolved?

@stale stale bot added the Stale No recent activity label Aug 22, 2020
@madmongo1 madmongo1 self-assigned this Aug 26, 2020
@stale stale bot removed the Stale No recent activity label Aug 26, 2020
@madmongo1
Copy link
Collaborator Author

merged with #2037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants