Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle expired timers in basic_stream transfer_op #2866

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented May 13, 2024

Previously, the code only handled expired timers when the buffer was empty.

Previously, the code only handled expired timers when the buffer was empty.
@ashtum ashtum force-pushed the fix-basic_stream-transform_op-with-expired-timers branch from 11b3a83 to ff3244a Compare May 13, 2024 07:55
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (95f0cfb) to head (ff3244a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2866      +/-   ##
===========================================
- Coverage    93.05%   93.02%   -0.04%     
===========================================
  Files          178      178              
  Lines        13688    13694       +6     
===========================================
+ Hits         12738    12739       +1     
- Misses         950      955       +5     
Files Coverage Δ
include/boost/beast/core/detail/stream_base.hpp 100.00% <100.00%> (ø)
include/boost/beast/core/impl/basic_stream.hpp 85.61% <100.00%> (-0.50%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f0cfb...ff3244a. Read the comment docs.

@ashtum ashtum merged commit 2dcdef3 into boostorg:develop May 13, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants