Fix CMake tests when using dynamic libraries #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## shared_build_test #162 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 2 2
Lines 18 18
Branches 7 7
===================================================
Hits 18 18 Continue to review full report at Codecov.
|
Flamefire
force-pushed
the
shared_build_fix
branch
from
e58ffff
to
eede6c3
Compare
On Windows DLLs need to be either in PATH or in the same folder as the executable. The latter is easy to achieve by setting CMAKE_RUNTIME_OUTPUT_DIRECTORY which puts all runtime files (exe, dll, so) into the specified folder. So do that.
Avoids the repetition. Use a subfolder of /tmp which is unlikely to exist. Additionally using $HOME may cause trouble due to path translation on Windows-Bash
To find dynamic libraries which are only indirect dependencies the variable LD_LIBRARY_PATH (Linux) or PATH (Windows) must contain the folder of the binaries.
Flamefire
force-pushed
the
shared_build_fix
branch
from
eede6c3
to
96dab18
Compare
|
Quick ping. Any comments on this solution? Especially as it is meant as a C&P solution for most (all?) Boost repos |
|
I don't see anything wrong with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows DLLs need to be either in
PATHor in the same folder as the executable.On Linux either RPath is required to be set (usually cleared when installing the library) or the files need to be in
LD_LIBRARY_PATH