Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes required by MSVC-15.5. #198

Merged
merged 11 commits into from
Dec 12, 2017
Merged

Apply changes required by MSVC-15.5. #198

merged 11 commits into from
Dec 12, 2017

Conversation

jzmaddock
Copy link
Collaborator

No description provided.

@pdimov
Copy link
Member

pdimov commented Dec 9, 2017

By default (that is, without permissive-) I get failures in config_test because of two-phase lookup.

@jzmaddock
Copy link
Collaborator Author

I thought /permissive- was the default for all new projects? The appveyor tests pass.

In any case we need a solution, and I don't see an easy one as there appears to be no way of detecting /permissive- ? I do note that nothing in Boost is using BOOST_NO_TWO_PHASE_NAME_LOOKUP at present so maybe this is moot?

@pdimov
Copy link
Member

pdimov commented Dec 10, 2017

New IDE projects are one thing, but in this way you're going to get test failures in the matrix. Appveyor passes because you test with /permissive- there.

@OlafvdSpek
Copy link
Contributor

Config.MSVC-14.5: complete configuration of new compiler features.

15.5?

PRINT_MACRO(_DLL);
PRINT_MACRO(_ISO_VOLATIL);
Copy link
Member

@pdimov pdimov Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Shouldn't this be _ISO_VOLATILE?

@jzmaddock
Copy link
Collaborator Author

Just out of curiosity, did my replies to your comments (thanks!) come though, or has Github junked them as I don't see them here?

@OlafvdSpek
Copy link
Contributor

OlafvdSpek commented Dec 12, 2017 via email

@OlafvdSpek
Copy link
Contributor

OlafvdSpek commented Dec 12, 2017 via email

@jzmaddock
Copy link
Collaborator Author

Mine? I saw commits but no replies I think.

OK, not getting through then :(

BTW, is this targeted for 1.66.0, 1.66.1 or 1.67?

Whatever comes after 1.66...

@jzmaddock jzmaddock merged commit ae3c914 into develop Dec 12, 2017
@s-martin
Copy link

As Microsoft seems to release new compiler versions in much shorter intervals now, are there any ideas yet, how this can be covered by Boost releases?

Are there any workarounds documented for Boost users to overcome the "Unknown compiler" messages, while there is no Boost release, which covers this?

@danieljames
Copy link
Contributor

It should say in the warning message, "Define BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE to suppress this message".

@s-martin
Copy link

@danieljames it doesn't, but thanks for the info. I'lll check it out.

@danieljames
Copy link
Contributor

Sorry, that message is added in the new release, coming soon hopefully.

@jzmaddock jzmaddock deleted the msvc_15_5 branch November 2, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants