Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real_allocator to find allocator when rebinding #115

Closed

Conversation

ecatmur
Copy link

@ecatmur ecatmur commented Apr 17, 2019

After 83bb62f the allocator parameter of
e.g. small_vector can be void. Use real_allocator to convert this to the
actual allocator used by the container.

example (works up to 1.69, breaks in 1.70):

#include <boost/container/flat_map.hpp>
#include <boost/container/small_vector.hpp>
boost::container::flat_map<int, int, std::less<>,
    boost::container::small_vector<std::pair<int, int>, 7>> m;

ecatmur and others added 2 commits April 17, 2019 14:55
After 83bb62f the allocator parameter of
e.g. small_vector can be void. Use real_allocator to convert this to the
actual allocator used by the container.
nb. I also tried std::vector and stable_vector, but these didn't work.
@igaztanaga
Copy link
Member

Thanks for the report. I've cherry-picked the first commit:

b075bce

Thanks to your test case, I've found another problem: Issue #118. I will add new test cases to test flat_map and flat_set as adaptors.

@igaztanaga igaztanaga closed this Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants