Fix splice for slist #64
Conversation
The call of the splice method with iterators leads to an infinite loop inside common_slist_algorithms::get_previous_node
slist<int> lst1 = { 0, 1, 2, 3 };
slist<int> lst2;
lst2.splice(lst2.begin(), lst1, lst1.begin());
expected:
lst1 == { 1, 2, 3 }
lst2 == { 0 }
| #if defined(BOOST_GCC) && (BOOST_GCC >= 50000) | ||
| #pragma GCC diagnostic ignored "-Wsized-deallocation" | ||
| #endif | ||
|
|
||
| void* operator new[](std::size_t count) BOOST_CONTAINER_NEW_EXCEPTION_SPECIFIER | ||
| void* operator new[](std::size_t count) BOOST_NOEXCEPT_IF(false) |
There was a problem hiding this comment.
We need to support older containers that don't have noexcept and avoid warnings that tell us that new should throw std::bad_alloc. What is the problem with current code?
There was a problem hiding this comment.
Hm. I do not really understand why this commit is displayed here. To fix the splice it has nothing to do. I did this local fix in my repository only to fix the build. But if you look at the Travis CI build (8.2), you can see next error:
libs/container/test/global_resource_test.cpp:42:41: error: ISO C++17 does not allow dynamic exception specifications [-Wdynamic-exception-spec]
void* operator new[](std::size_t count) BOOST_CONTAINER_NEW_EXCEPTION_SPECIFIER
libs/container/test/global_resource_test.cpp:34:52: note: expanded from macro 'BOOST_CONTAINER_NEW_EXCEPTION_SPECIFIER'
#define BOOST_CONTAINER_NEW_EXCEPTION_SPECIFIER throw(std::bad_alloc)
libs/container/test/global_resource_test.cpp:42:41: note: use 'noexcept(false)' instead
There was a problem hiding this comment.
Ok, can you please open a new issue for this error, adding as much context as you can (compiler, version, flags, etc.) . I'll close this issue as your main commit was already merged. Many thanks for the report and the patch.
|
Fixed cherry-picking commit: Many thanks for the report. |
The call of the splice method with iterators leads to an infinite loop inside common_slist_algorithms::get_previous_node
slist lst1 = { 0, 1, 2, 3 };
slist lst2;
lst2.splice(lst2.begin(), lst1, lst1.begin());
expected:
lst1 == { 1, 2, 3 }
lst2 == { 0 }