MSVC build failures: special_value_from_string redefinition
#143
Comments
|
Ok I'll look at it, but if this is the case our system is broken -- the regressions have been running clean for 2 weeks...not to mention that that change ran clean on all the msvc compilers before committed. |
|
This problem is also present in master. It reproduces only when you include both I would suggest adding a test generator for header self-sufficiency (here is an example and the associated test template) and a test that includes all library headers at once. The latter would have shown this problem, the former would trigger if there are any missing includes. If you trust |
This resolves different attributes applied to the function definition in parsers.hpp and greg_month.hpp. The function is now inline and defined in parsers.hpp. Also, the commit converts tabs to spaces and trims trailing spaces. Fixes boostorg#143.
|
Thanks for taking this on before I got to it :) This did need fixing before 1.73 and was clearly induced by my recent changes. |
This resolves different attributes applied to the function definition in parsers.hpp and greg_month.hpp. The function is now inline and defined in parsers.hpp. Also, the commit converts tabs to spaces and trims trailing spaces. Fixes boostorg#143.
This resolves different attributes applied to the function definition in parsers.hpp and greg_month.hpp. The function is now inline and defined in parsers.hpp. Also, the commit converts tabs to spaces and trims trailing spaces. Fixes boostorg#143.
* Added a test generator for whether all public headers are self-contained. The generator creates a compile test for every public header, unless BOOST_DATE_TIME_TEST_WITHOUT_SELF_CONTAINED_HEADER_TESTS environment variable is set to 1. * Only enable self-contained header tests on a few jobs. There is no point in performing self-contained header tests on every compiler configuration, so running them only on some saves CI time. * Make public headers self-contained. This commit: - Adds missing includes. - Adjusts gregorian namespace qualification in a few places to use use equivalent symbols from date_time and not have to include gregorian headers. - Converts tabs to spaces and trims trailing spaces. This makes the self-contained header tests pass on Linux. * Move special_value_from_string definition to parsers.hpp. This resolves different attributes applied to the function definition in parsers.hpp and greg_month.hpp. The function is now inline and defined in parsers.hpp. Also, the commit converts tabs to spaces and trims trailing spaces. Fixes #143. * Convert tabs to spaces and trim trailing spaces.
Current develop (revision 4a46476) fails to compile with any MSVC version, as can be seen here:
The text was updated successfully, but these errors were encountered: