Avoid implicit cast from size_t to uint32_t #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we have an error on line 42 of
path_from_handle.hpp
.With the XCode 14.1 update, the
-Wshorten-64-to-32
flag has somehow been enabled in our project and shows this warning when including#include "boost/dll/import.hpp"
According to the linked docs on line 37,
_dyld_get_image_name()
takes auint32_t
but here is passed asize_t
. With-Wconversion
enabled this creates a warning whensize_t
is a larger type thanuint32_t
._dyld_image_count()
returns auint32_t
so I think this can be solved by not casting tosize_t
in the first place.Edit: I removed the
std::
prefix becausemach-o/dyld.h
has the type un-prefixed and it seemsuint32_t
is not part of the C++03 standard.