Fixed strict aliasing violation. #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed C-style cast and dereference to std::memcpy. Exactly mirrors other code already in the file.
|
I'm going to merge this by rebasing onto develop, so it won't appear here. Although I don't really like the existing code much, someone else wrote it. I'm not sure if there's a better way though. I suppose std::memcpy can have a compiler specific implementation if it needs to, so it can solve problems that we can't. |
|
It's in commit d5dc503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed C-style cast and dereference to std::memcpy. Exactly mirrors other code already in the file.