New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs nesting and copying on c++03. #154

Merged
merged 5 commits into from Oct 15, 2017

Conversation

Projects
None yet
1 participant
@Flast
Collaborator

Flast commented Oct 14, 2017

I hope this PR fixes vector_nest, deque_nest, and deque_copy compile errors on MSVC: Visual Studio 2015 should be passed on appveyor.

Flast added some commits Oct 13, 2017

Fixed incorrect overload resolution.
Those functions should not be chosen for copying/moving.
Added copy assign to deque(03).
move ctor will delete defaulted copy assign.
@Flast

This comment has been minimized.

Show comment
Hide comment
@Flast

Flast Oct 15, 2017

Collaborator

I confirmed those tests turn out fine.

Collaborator

Flast commented Oct 15, 2017

I confirmed those tests turn out fine.

@Flast Flast merged commit 26f6971 into develop Oct 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Flast Flast deleted the bugfix/forwarding-on-non-variadics branch Oct 15, 2017

@Flast Flast referenced this pull request Nov 14, 2017

Closed

Failure on msvc-12.0 #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment