Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Just move non-variadics into its own cpp03 dir. #80

Merged
merged 2 commits into from
Jun 15, 2015

Conversation

Flast
Copy link
Collaborator

@Flast Flast commented Jun 15, 2015

As I mentioned in #57 (comment) .

After this, #57 will be more clean like this, Flast/boost-fusion@78afb4d...736cce8 .

Warning: Currently, this PR doesn't take care about include paths. Hang on until I pushing a commit to fix.

@Flast Flast changed the title Just move non-variadics into its own cpp03 dir. [WIP] Just move non-variadics into its own cpp03 dir. Jun 15, 2015
@djowel
Copy link
Collaborator

djowel commented Jun 15, 2015

Yes! :-)

djowel added a commit that referenced this pull request Jun 15, 2015
[WIP] Just move non-variadics into its own cpp03 dir.
@djowel djowel merged commit 6df8d5a into boostorg:develop Jun 15, 2015
@awulkiew
Copy link
Member

I noticed that this change broke one of the Geometry tests: test/geometries/adapted.cpp, in the regression matrix called geometries_boost_fusion, see this one for instance. The fragment of the error message is:

D:\t08\run\boost_root\boost/fusion/container/list/cons_iterator.hpp(84) : error C2065: 'list' : undeclared identifier
...
D:\t08\run\boost_root\boost/fusion/container/list/cons_iterator.hpp(93) : error C2065: 'list' : undeclared identifier
...
D:\t08\run\boost_root\boost/fusion/container/list/cons_iterator.hpp(106) : error C2065: 'Cons' : undeclared identifier
...

Is it an intended regression or a bug in Fusion? If the former is true then how should the test be rewritten?

@vtnerd
Copy link
Contributor

vtnerd commented Jun 16, 2015

This is a WIP, and will hopefully be fixed with this pull request.

@mjcaisse
Copy link
Member

In the future we should probably make a feature branch from develop and use that for long running WIP. That allows manageable PR's for review and doesn't break development builds. Once the long running development is complete and stable it can be merged to the develop branch.

@vtnerd
Copy link
Contributor

vtnerd commented Jun 16, 2015

Is it possible to run the automated tests for these feature branches? I guess each project could set this up independently, but having the test matrix automatically track "feature/xxx" would be nice since it tests on more platforms than the usual free-online tools. This might create too much overhead for that system though.

@mjcaisse
Copy link
Member

Our Bamboo servers can detect the feature branches and run the tests. This isn't helpful to the community yet but I hope it will be soon.

@djowel
Copy link
Collaborator

djowel commented Jun 16, 2015

Yes, agreed on all counts. We cannot destabilise devel. I assumed that this PR did not break anything. My bad. I missed the Warning from Flast.

@Flast
Copy link
Collaborator Author

Flast commented Jun 17, 2015

This is a WIP, and will hopefully be fixed with this pull request.

@vtnerd , Thank you your follow-up.

Yes, agreed on all counts. We cannot destabilise devel. I assumed that this PR did not break anything.

@djowel , if WIP PR misleads you, I won't open WIP PR.

@djowel
Copy link
Collaborator

djowel commented Jun 17, 2015

@Flast , it's my bad. anyway, i think we should do as michael suggests using feature branches. for immediate WIP PRs, is it not possible to have it in such a way as not to break the build?

@Flast
Copy link
Collaborator Author

Flast commented Jun 17, 2015

@djowel , I agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants