-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Just move non-variadics into its own cpp03 dir. #80
Conversation
Yes! :-) |
[WIP] Just move non-variadics into its own cpp03 dir.
I noticed that this change broke one of the Geometry tests: test/geometries/adapted.cpp, in the regression matrix called
Is it an intended regression or a bug in Fusion? If the former is true then how should the test be rewritten? |
This is a WIP, and will hopefully be fixed with this pull request. |
In the future we should probably make a feature branch from develop and use that for long running WIP. That allows manageable PR's for review and doesn't break development builds. Once the long running development is complete and stable it can be merged to the develop branch. |
Is it possible to run the automated tests for these feature branches? I guess each project could set this up independently, but having the test matrix automatically track "feature/xxx" would be nice since it tests on more platforms than the usual free-online tools. This might create too much overhead for that system though. |
Our Bamboo servers can detect the feature branches and run the tests. This isn't helpful to the community yet but I hope it will be soon. |
Yes, agreed on all counts. We cannot destabilise devel. I assumed that this PR did not break anything. My bad. I missed the Warning from Flast. |
@Flast , it's my bad. anyway, i think we should do as michael suggests using feature branches. for immediate WIP PRs, is it not possible to have it in such a way as not to break the build? |
@djowel , I agreed. |
As I mentioned in #57 (comment) .
After this, #57 will be more clean like this, Flast/boost-fusion@78afb4d...736cce8 .
Warning: Currently, this PR doesn't take care about include paths. Hang on until I pushing a commit to fix.