Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples in develop branch use old IO extension #40

Closed
mloskot opened this issue Mar 14, 2018 · 7 comments
Closed

Examples in develop branch use old IO extension #40

mloskot opened this issue Mar 14, 2018 · 7 comments
Assignees
Labels
cat/annoyance Not a bug, not a feature, but something that should be improved ext/io boost/gil/extension/io/
Milestone

Comments

@mloskot
Copy link
Member

mloskot commented Mar 14, 2018

There examples in the current develop branch have not been ported to the new IO v2 extension, so they still include the old IO headers. For example:

dynamic_image.cpp(20):#include <boost/gil/extension/io/jpeg_dynamic_io.hpp>
interleaved_ptr.cpp(35):#include <boost/gil/extension/io/jpeg_dynamic_io.hpp>
x_gradient.cpp(18):#include <boost/gil/extension/io/jpeg_dynamic_io.hpp>
affine.cpp(25):#include <boost/gil/extension/io/jpeg_io.hpp>
convolution.cpp(25):#include <boost/gil/extension/io/jpeg_io.hpp>
histogram.cpp(23):#include <boost/gil/extension/io/jpeg_io.hpp>
mandelbrot.cpp(20):#include <boost/gil/extension/io/jpeg_io.hpp>
packed_pixel.cpp(36):#include <boost/gil/extension/io/jpeg_io.hpp>
resize.cpp(25):#include <boost/gil/extension/io/jpeg_io.hpp>
@stefanseefeld stefanseefeld added this to the The Grand Merge milestone Mar 18, 2018
@chhenning
Copy link
Contributor

We can remove those tests. I think I have added the tests to ensure the new io is backwards compatible. Meaning the old io's interface is still functioning with the new io.

@mloskot
Copy link
Member Author

mloskot commented Mar 20, 2018

If there are no equivalents based on IO v2, I think it's worth to port them.

@mloskot mloskot self-assigned this Mar 20, 2018
@chhenning
Copy link
Contributor

Oh, I think I misunderstood you. You're not talking about tests but actual library code. Let me see

@mloskot
Copy link
Member Author

mloskot commented Mar 20, 2018

@chhenning I think I've got confused myself to: I reported exampels you responded those tests :)

Let's rewind and talk about the examples (resize, mandelbrot, etc.). I suggest that instead of removing them, they should be ported to the new IO.

@chhenning
Copy link
Contributor

I agree. We can make them part of the test suite.

@chhenning
Copy link
Contributor

I didn't realize there are "Examples". Might be good to include them in the documentation.

@mloskot
Copy link
Member Author

mloskot commented Mar 20, 2018

The ancient GIL docs http://stlab.adobe.com/gil/documentation.html include them in the list of Samples on the front page. BTW, this old docs should be put down as they are doing bad publicity for Boost.GIL, IMHO.

@mloskot mloskot removed this from the The Grand Merge milestone Jun 25, 2018
@mloskot mloskot added the ext/io boost/gil/extension/io/ label Oct 23, 2018
@mloskot mloskot added this to the Boost 1.70 milestone Dec 17, 2018
@mloskot mloskot added the cat/annoyance Not a bug, not a feature, but something that should be improved label Dec 17, 2018
mloskot added a commit to mloskot/gil that referenced this issue Dec 17, 2018
Following release of the new IO in Boost 1.68, the examples
stopped compiling.

Fixes boostorg#40
mloskot added a commit that referenced this issue Dec 18, 2018
Following release of the new IO in Boost 1.68, the examples stopped compiling.

Fixes #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/annoyance Not a bug, not a feature, but something that should be improved ext/io boost/gil/extension/io/
Projects
None yet
Development

No branches or pull requests

3 participants