Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image constructor from other image #477

Merged
merged 4 commits into from
Apr 11, 2020

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Apr 8, 2020

Description

Fixes

template <typename P2, bool IP2, typename Alloc2>
image(const image<P2,IP2,Alloc2>& img)

giving

include/boost/gil/image.hpp:108:84: error: 'std::size_t boost::gil::image<boost::gil::pixel<unsigned char, boost::gil
::layout<boost::mp11::mp_list<boost::gil::gray_color_t> > >, false, std::allocator<unsigned char> >::_align_in_bytes' is
 private within this context
     image(const image<P2,IP2,Alloc2>& img) : _memory(nullptr), _align_in_bytes(img._align_in_bytes), _alloc(img._alloc)
                                                                                ~~~~^~~~~~~~~~~~~~~
../include/boost/gil/image.hpp:345:20: note: declared private here
     std::size_t    _align_in_bytes;

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@mloskot mloskot added the cat/bug But reports and bug fixes label Apr 8, 2020
include/boost/gil/image.hpp Outdated Show resolved Hide resolved
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdebionne LGTM, thanks!

I made several minor comments, not requests for changes though.

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mloskot
Copy link
Member

mloskot commented Apr 9, 2020

Let's wait for the CI builds.

I'm not sure if it will make it to Boost 1.73, let's see.

@mloskot mloskot added this to the Boost 1.74+ milestone Apr 10, 2020
@mloskot mloskot merged commit 05ee4c8 into boostorg:develop Apr 11, 2020
@sdebionne sdebionne deleted the fix-image-ctor branch April 14, 2020 06:55
mloskot added a commit that referenced this pull request Jul 11, 2020
* develop:
  Collect release notes for Boost 1.74
  Fix missing header in numeric/kernel.hpp to make it self-contained (#502)
  Use perfect forwading from apply_operation to visit (#491)
  Fix typos and replace mpl with mp11 in tutorial (#494)
  Implemented mechanism to reverse kernel_2d (#489)
  added missing const& in extend_boundary parameters (#490)
  Add initializing image constructor (#486)
  Fix interleaved_view factory using point<std::ptrdiff_t> for dimension (#487)
  RELEASES.md: Remove beta tag [ci skip]
  Replace Boost.Variant with Boost.Variant2 (#474)
  Fix error plane_view_t is not a class or namespace name (#481)
  Fix image constructor from other image (#477)
  Fix overflow in RGB to CMYK32 conversion (#470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug But reports and bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants