Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initializing image constructor #486

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Add initializing image constructor #486

merged 4 commits into from
Apr 24, 2020

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Apr 20, 2020 •
edited by mloskot
Loading

Description

Add a new constructor to any_image.

References

Fixed #453

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image labels Apr 20, 2020
@mloskot mloskot self-requested a review April 21, 2020 18:41
mloskot
mloskot requested changes Apr 21, 2020
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it's marked as draft. Is it work in progress?

The change is trivial, but would be nice to have a minimal test case.

@sdebionne sdebionne marked this pull request as ready for review April 22, 2020 06:25
@sdebionne
Copy link
Contributor Author

Yes it was a draft until I added a minimal test case.

mloskot
mloskot requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I just have to ask for the tiny update in Jamfile and the copyright update.

test/extension/dynamic_image/CMakeLists.txt Show resolved Hide resolved
include/boost/gil/extension/dynamic_image/any_image.hpp Show resolved Hide resolved
@mloskot mloskot merged commit cee21c2 into boostorg:develop Apr 24, 2020
@mloskot mloskot added this to the Boost 1.74+ milestone Apr 24, 2020
@sdebionne sdebionne deleted the add-initializing-ctor-rvalue branch April 27, 2020 07:41
mloskot added a commit that referenced this pull request Jul 11, 2020
@mloskot
Initial merge of develop branch for Boost 1.74 release
0ac2e42 
* develop:
  Collect release notes for Boost 1.74
  Fix missing header in numeric/kernel.hpp to make it self-contained (#502)
  Use perfect forwading from apply_operation to visit (#491)
  Fix typos and replace mpl with mp11 in tutorial (#494)
  Implemented mechanism to reverse kernel_2d (#489)
  added missing const& in extend_boundary parameters (#490)
  Add initializing image constructor (#486)
  Fix interleaved_view factory using point<std::ptrdiff_t> for dimension (#487)
  RELEASES.md: Remove beta tag [ci skip]
  Replace Boost.Variant with Boost.Variant2 (#474)
  Fix error plane_view_t is not a class or namespace name (#481)
  Fix image constructor from other image (#477)
  Fix overflow in RGB to CMYK32 conversion (#470)
@sdebionne sdebionne mentioned this pull request Oct 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

Assignees
No one assigned
Labels
cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image
Projects
None yet
Milestone
Boost 1.74
Development

Successfully merging this pull request may close these issues.

[dynamic] Initialization issue
2 participants
@sdebionne @mloskot