-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codecov to GitHub Actions #564
Conversation
Please don't worry about commits, I will squash them in a nice single commit :) |
Hello @mloskot, I need some help now. I am not much experienced with codecov. But as much I know public repositories don't need tokens to upload reports. The GitHub Actions is perfectly working. You can see the last run here: https://github.com/boostorg/gil/pull/564/checks?check_run_id=1971222975#step:6:1049 It is also being picked by Codecov, which is good But for some reason, reports are not showing up. I don't know what else is missing. |
@avinal I'm afraid I have nothing helpful to offer. I had been struggling in the past with Codecov, https://github.com/codecov/codecov-bash/search?q=mloskot&type=issues, without having a slightest clue what was going wrong. |
Ohh, I will try to solve this. 👍 |
Hello @mloskot, There are more things we may add:
P.S - By no means it was a |
Codecov Report
@@ Coverage Diff @@
## develop #564 +/- ##
===========================================
+ Coverage 77.81% 78.59% +0.78%
===========================================
Files 110 117 +7
Lines 4367 4980 +613
===========================================
+ Hits 3398 3914 +516
- Misses 969 1066 +97
Continue to review full report at Codecov.
|
@avinal Awesome!
AFAIR, my experience with this file was similar. I sometimes used it to disable Codecov comment I think we could experiment with the comment configuration to avoid unnecessary PR comments, e.g.
We could add two badges to the statuses in the README:
Well, the difficulty was judge from the GIL point :-) Kudos for your persistence! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good. Thanks!
I'd like to merge it as it is.
If you'd like to apply any further tweaks, then I suggest to do it in new PRs
Ohh actually I was adding those two changes. I will open a new PR, no worries 😊. Thanks a lot |
Sorry for not synchronising our actions better. Please, do new PRs, thanks |
I incorrectly put |
Delete coverage.sh as unused Closes boostorg#565
Delete coverage.sh as unused Closes boostorg#565
Delete coverage.sh as unused Closes boostorg#565
Delete coverage.sh as unused Closes boostorg#565
Delete coverage.sh as unused Closes boostorg#565
Description
Adds Codecov GitHub Actions
References
#548 & #532
Tasklist