Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release with Boost 1.80 #667

Closed
6 tasks done
mloskot opened this issue May 12, 2022 · 10 comments
Closed
6 tasks done

Prepare for release with Boost 1.80 #667

mloskot opened this issue May 12, 2022 · 10 comments
Assignees
Milestone

Comments

@mloskot
Copy link
Member

mloskot commented May 12, 2022

Following the #663 discussion, we are going to perform the grand true merge of develop into master in order to prepare for release all of the fixes and features (GSoC too) that have been developed over the Boost 1.76.0, that is the last Boost release with anything GIL.

Steps:

  1. Merge
  2. Build locally before git push
  3. Push
  4. Review CI status
  5. Collect release notes to RELEASES.md
  6. Copy release notes to https://github.com/boostorg/website/ (special kudos go to @striezel for his huge helps with the docs and release notes!)

Changes

Below is initial, as on 12 May 2022, log of commits in form convenient to review that will merged from current develop into master for release with Boost 1.80:

git log origin/master..develop --reverse --pretty=format:" | %cs | [%h](http://github.com/boostorg/gil/commit/%H) | %s |" | nl | sed -E 's/^\s/\|/g'
# Date Hash Subject
1 2020-10-05 f6a35532f Fix typo in copyright headers (#521)
2 2020-10-10 f7e83e0ba Fix conversion of rgb to signed cmyk(#479) (#522)
3 2020-10-11 f374a672a Add image constructor from compatible view (#520)
4 2020-11-10 8b1c2d3ea Boost 1.75 release notes: plan to phase out GCC 5 and introduce C++14
5 2020-11-22 6fc7d7541 Removing unnecessary cast in hsv.cpp (#530)
6 2020-11-22 09911cd1c ci: Boost.Numeric is no longer a dependency [ci skip]
7 2020-11-22 8d0490630 docs: Update CONTRIBUTING.md [ci skip]
8 2020-12-16 2b1e4665d Add "cxxstd" json field (#531)
9 2021-01-04 e1c69d171 Add codecov coverage (#532)
10 2021-01-11 0c0fe1ae7 build: Switch conan packages from bincrafters to conan.io (#537)
11 2021-01-20 68cdbdd2e Add inverse function for matrix3x2 (#527)
12 2021-01-20 853bc1266 Fix typo in copyright headers (#524)
13 2021-01-21 eef475e27 ci: Temporarily set B2_VERBOSE=0 for CircleCI
14 2021-01-22 470923be3 Fix default ctor of homogeneous_color_base for reference pixel elements (#542)
15 2021-01-22 cb5bc9d8c Add Perona–Malik anisotropic diffusion algorithm (#500)
16 2021-01-23 b23c5e75b doc: Display GIL is header-only in README
17 2021-01-23 0e372a10b docs: Display GIL is header-only in README
18 2021-01-24 3e729e5da Add histogram class and related functionality (#499)
19 2021-01-24 fb7512c29 Add histogram equalization feature (#514)
20 2021-01-24 77255e9e6 Add histogram matching algorithm (#515)
21 2021-01-24 b82aed8f8 Implement hstack and vstack (#506)
22 2021-01-24 a68a95d5f Add code for ahe algorithm (#516)
23 2021-01-25 81b4dc08b ci: Add configuration for GitHub Actions (#544)
24 2021-01-25 a37f12b3e Add implementation of Hough transforms (#512)
25 2021-01-26 434e78f76 ci: R.I.P. Travis CI - Long live GitHub Actions
26 2021-01-27 4e0f815f5 build: Remove most of uses of cxxflags from test/Jamfile (#550)
27 2021-01-28 6f0a06136 docs: Clarify PR update procedure in CONTRIBUTING.md [ci skip]
28 2021-01-28 5d63cf679 Fix more warnings in examples
29 2021-01-28 063385398 Fix warnings about abs called without std qualification
30 2021-01-28 6007d7466 Fix some clang -Wunused-variable warnings
31 2021-01-28 422ca82fe Removed two instaces of boost.mpl (#551)
32 2021-01-30 2e2764225 Support constructing a planar image from interleaved image (#552)
33 2021-02-02 90f7952b0 Fixed most of warnings in examples and some in core library (#545)
34 2021-02-02 d923a8f37 Declare laplacian_function::get_directed_offsets as inline
35 2021-02-02 c7847f4d6 Fix warning: returning reference to local temporary object (#556)
36 2021-02-03 04daae716 Fix warning: comparison of integer expressions of different signedness
37 2021-02-03 58804ecb2 Remove and other cruft from Jamfile (#557)
38 2021-02-03 f58f3a23a Disable warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare]
39 2021-02-04 8337f47ae Review and update includes in boost/gil.hpp (#559)
40 2021-02-05 c3b3d35aa Fix sphinx installation link in docs readme (#560)
41 2021-02-09 2676d3180 ci: Disable AppVeyor job using CMake to avoid timeouts
42 2021-02-13 1e8526797 Added all standard morphological transformations (#541)
43 2021-02-19 a8cb36449 doc: Add Compiling section with C++ version and compilers support
44 2021-02-28 a82af6d25 ci: Add Codecov to GitHub Actions (#564)
45 2021-03-01 33ab3cfc1 added missing header guards (#568)
46 2021-03-01 ec25950af added missing copyright info (#569)
47 2021-03-01 ad007ab92 ci: Add Codecov badge and codecov.yml file (#567)
48 2021-03-01 093117d56 Repoint B2 refs to new non-boostorg home. (#570)
49 2021-03-01 f18445f90 Repoint B2 refs to new non-boostorg home. (#571)
50 2021-03-02 0778069b8 Switch docs deployment from Travis CI to GitHub Actions (#563)
51 2021-03-02 8bd241312 ci: Remove GCC 5 on GitHub Actions and Azure Pipelines (#572)
52 2021-03-05 745d033ef ci: Use GitHub Actions automatic GITHUB_TOKEN secret in docs workflow
53 2021-03-09 392ac4996 Rotation of image by any arbitrary angle from its center (#565)
54 2021-03-10 6da59cc33 docs: Updated GA workflow to publish with peaceiris/action-gh-pages (#574)
55 2021-03-18 b8564e256 Fix any_image_view::const_t (#526)
56 2021-03-24 dc9ba74cb Add docs for histogram (#503)
57 2021-03-24 6e91e4bf5 Update image url links for docs for histogram (#586)
58 2021-03-28 bc3a6c0db Add rasterizer support for ellipse (#585)
59 2021-04-02 cea6ef275 ci: Fix availability of toolsets in updated Ubuntu images of GitHub Actions (#589)
60 2021-04-02 2ad274cc8 ci: Remove cxxstd=14 from clang 3.5 job on GitHub Actions (#590)
61 2021-04-03 bbdce36a1 docs: Correct typos in documentation (#592)
62 2021-05-06 0a21d741c test: Verify core IO headers are self-contained
63 2021-05-11 4738a3829 test: Catch up IO with switch to variant2 migration (#607)
64 2021-05-23 d65cc5822 Update CONTRIBUTING.md
65 2021-05-30 7dd61209a Add remaining pieces of documentation in convolve.hpp (#611)
66 2021-06-11 effd078b3 Fix C++20 incompatibilities in IO extensions
67 2021-07-16 2cc525a2d Fix for_each_pixel for non 1d iterable views
68 2021-10-04 327952325 Update pixel design documentation for MP11 changes (#626)
69 2021-10-05 c9b339e5d Merge pull request #617 from fmorgner/fix-c++20-ctor-incompatibility
70 2021-10-30 a328bef94 Add a Boost-friendly subproject case to CMakeLists (#614)
71 2021-11-08 b6526deb7 Remove remaining references to MPL in the documentation (#631)
72 2021-11-10 0b24f4cdb Ensure all examples build without error (#628)
73 2021-12-16 4531c3d56 docs: Fix TOC link to B2 in CONTRIBUTING.md (#632)
74 2022-02-05 2db5fe9f4 Fix warning: unused variable ‘r_squared’ [-Wunused-variable]
75 2022-02-05 0accacdbe Fix warning: comparison of integer expressions of different signedness
76 2022-02-06 5dcdf53c0 Fix warning: unused variable in diffusion.hpp (#635)
77 2022-02-09 c7aba23c7 Fix convolve_2d for images with float32_t channel model (#577)
78 2022-02-09 199520179 Refactor CMake test config (#634)
79 2022-02-18 2562e1124 numeric extension move into core 1
80 2022-02-18 baf246a72 numeric extension move into core part 2
81 2022-02-18 483915cb2 numeric extension move into core part 3
82 2022-02-18 87a3157c4 numeric extension move into core part 4
83 2022-02-18 9bd8642f6 numeric extension move into core part 5
84 2022-02-22 f4c70a860 Add support for to IO (#636)
85 2022-03-01 da0655fb6 Merge pull request #621 from sdebionne/fix-620
86 2022-03-28 4943e403b chore: Bump CMake version in CMakeLists.txt
87 2022-04-06 63f5837bd Removed deprecated.hpp (#627)
88 2022-04-07 bb080b544 ci: Replace Ubuntu 16.04 with Ubuntu 18.04 in some GitHub Actions jobs (#640)
89 2022-04-07 a38f890fe ci: Fix Clang 9 build on GitHub Actions (#641)
90 2022-04-07 c1c87ee03 ci: Switch Azure's macOS build to supported OS version (#643)
91 2022-04-09 cf1e6b11b build: Define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING for MSVC
92 2022-04-09 09c3464ad ci: Switch GitHub Action's MSVC build to supported OS version (#644)
93 2022-04-12 8d83cdca2 ci: Remove /std:c++latest from MSVC build variants
94 2022-04-12 22be33bb6 ci: Remove cxxstd=2a from GitHub Actions ci.yml workflow
95 2022-04-12 41167f600 ci: Add Boost.Align to transitive dependencies on AppVeyor
96 2022-04-12 016ae7877 ci: Stop building on CircleCI
97 2022-04-12 c0cb52d1f ci: Remove CircleCI traces from README.md
98 2022-04-14 39089c5f8 docs: Add Discussions to README.md
99 2022-04-21 caf92fa94 Renamed adaptive_he to adaptive_histogram_equalization (#638)
100 2022-04-26 4f83beb73 style: Remove trailing space characters (#651)
101 2022-04-26 9ed8fd2b4 ci: remove Windows Server 2016 from builds on Azure Pipelines (#652)
102 2022-04-26 791148660 fix: is_equal_to_sixteen in PNG I/O was less-than test (#650)
103 2022-04-27 9d526ed70 refactor: Renamed io/dynamic_io_new.hpp to io/detail/dynamic.hpp (#653)
104 2022-04-30 3289fe0bc refactor: Unified operation names for pixel and channel operations (#655)
105 2022-04-30 c063d1c18 feat: Added for_each_pixel overload for any_image (#648)
106 2022-05-03 36a45e3af fix documentation links in "See also" sections

Merge

/d/boost/gil (master|u= origin/master) $ git merge --no-ff develop
Auto-merging .github/workflows/ci.yml
CONFLICT (add/add): Merge conflict in .github/workflows/ci.yml
Auto-merging CMakeLists.txt
Auto-merging CONTRIBUTING.md
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
Auto-merging RELEASES.md
CONFLICT (content): Merge conflict in RELEASES.md
Auto-merging test/Jamfile
CONFLICT (content): Merge conflict in test/Jamfile
Auto-merging test/core/channel/algorithm_channel_relation.cpp
CONFLICT (content): Merge conflict in test/core/channel/algorithm_channel_relation.cpp
Automatic merge failed; fix conflicts and then commit the result.
...
Unmerged paths:
  (use "git add <file>..." to mark resolution)
        both added:      .github/workflows/ci.yml
        both modified:   README.md
        both modified:   RELEASES.md
        both modified:   test/Jamfile
        both modified:   test/core/channel/algorithm_channel_relation.cpp

/d/boost/gil (master|MERGING|u= origin/master) $ git add -A
/d/boost/gil (master|MERGING|u= origin/master) $ git merge --continue
[master 6ef11459a] Merge branch 'develop'

Build (local)

On Windows, using VS 2022, core only:

b2.exe cxxstd=11 variant=release address-model=64 libs/gil/test/core

On Linux, using gcc 10, all default tests

./b2 cxxstd=11 variant=release address-model=64 libs/gil/test

All pass.

@mloskot mloskot added this to the Boost 1.80 milestone May 12, 2022
@mloskot mloskot self-assigned this May 12, 2022
striezel added a commit to striezel-stash/gil that referenced this issue May 12, 2022
Includes changes up to commit 25 from the table shown in
<boostorg#667>.
mloskot pushed a commit that referenced this issue May 13, 2022
Includes changes up to commit 25 from the table shown in
<#667>.
striezel added a commit to striezel-stash/gil that referenced this issue May 13, 2022
Includes changes up to commit 106 (hash 36a45e3) from the table
shown in <boostorg#667>. Those are
all commits form the grand merge.

[ci skip]
striezel added a commit to striezel-stash/gil that referenced this issue May 13, 2022
Includes changes up to commit 106 (hash 36a45e3) from the table
shown in <boostorg#667>. Those are
all commits form the grand merge.

[ci skip]
mloskot pushed a commit that referenced this issue May 14, 2022
Includes changes up to commit 106 (hash 36a45e3) from the table
shown in <#667>. Those are
all commits form the grand merge.

[ci skip]
@mloskot mloskot linked a pull request May 23, 2022 that will close this issue
1 task
@mloskot
Copy link
Member Author

mloskot commented Jun 19, 2022

I've just pushed another merge from develop to master in b1d64ab

@mloskot
Copy link
Member Author

mloskot commented Jun 27, 2022

I've just pushed develop to master merge in b29f3da before the upcoming deadline on the 29th.

/cc @marco-langer

@marco-langer
Copy link
Contributor

Changes on the documentation are still possible until 6th of July according to the Boost 1.80 release schedule. Does this also include PRs on the examples? (IMO: yes, examples are part of the documentation)

@mloskot
Copy link
Member Author

mloskot commented Jun 28, 2022

Yes, of course. Documentation, examples, tests and stuff inside namespace boost::gil::detail can receive any changes - only major changes to public interface is not allowed.

I've been rushing with merging PRs but postponed updates to RELEASES.md notes.

@mloskot
Copy link
Member Author

mloskot commented Jun 29, 2022

I've just pushed, I think, the last major changes develop to master merge in bba6d62 before the upcoming deadline on the 29th.

We are free to make changes to docs, examples, tests, and other non-breaking changes.

@mloskot
Copy link
Member Author

mloskot commented Jul 5, 2022

Here is likely the final batch of changes to collect release notes for:

$ git log 36a45e3af..develop --reverse --pretty=format:" | %cs | [%h](http://github.com/boostorg/gil/commit/%H) | %s |" | nl | sed -E 's/^\s/\|/g'
# Date Hash Subject
1 2022-05-12 9666a95bc chore: Remove unused variable in diffusion.hpp (#666)
2 2022-05-13 f839504f2 Fixed io extension build error (#671)
3 2022-05-13 ec9f0b024 docs: Add partial release notes for Boost 1.80 (#670)
4 2022-05-14 fb8e389ad docs: Add remaining part of release notes for Boost 1.80 (#672)
5 2022-05-17 8caa148e0 docs: Added more release notes with GSoC work
6 2022-05-18 44d4ab8d4 ci: Disable g++-8 cxxstd=17 - segmentation fault for simple_all_formats test
7 2022-05-18 3090f866f fix: Re-allow devicen_t with two color components (#654)
8 2022-05-18 1be8c87c1 chore: do not use deprecated header in test or elsewhere (#675)
9 2022-05-18 d64e70dc8 docs: add release notes for issue #654 (#674)
10 2022-05-18 4ad824e8d ci: Remove clang 3.5 through 3.8 jobs based on Ubuntu 16.04
11 2022-05-24 dcae92f5c docs!: announce switch from C++11 to C++14 with Boost 1.80 (#677)
12 2022-05-26 6d312af51 chore!: deprecate any_color_converted_view (#678)
13 2022-05-28 98f49711d refactor: Make packed_pixel trivially copyable and assignable (#679)
14 2022-05-31 bab2a370f Fix Hough transform and move rasterization
15 2022-05-31 f87ee565c In depth explanation for Hough line
16 2022-05-31 cc39f1a00 Change "" includes into <>
17 2022-05-31 48d7ebffe Move diffusion and Hough transform
18 2022-05-31 b962a6a2d Edit Jamfile to new layout
19 2022-05-31 76dcca89f Add compile statements to Jamfile
20 2022-05-31 3965f2ab9 Remove migrated files
21 2022-05-31 45da54487 Removed redundant lines
22 2022-06-03 843ea374b Merge pull request #673 from simmplecoder/gsoc_2020_fixup
23 2022-06-05 2f7c3db5b chore: update metadata for switch to C++ 14 (#682)
24 2022-06-07 9ecdb876b Fix deprecation warning bug for gcc 10.2 (#683)
25 2022-06-12 1c6c427f5 fix: Added missing include guard to line rasterizer (#687)
26 2022-06-24 5273678bf fix: Wrong RGB -> HSL convertion (#505)
27 2022-06-24 c436ea3e6 fix: Add missing #include
28 2022-06-25 46731e6d4 chore: Correct include guard
29 2022-06-25 d50d85613 refactor: Make with_tolerance reusable across other tests
30 2022-06-25 57c616d27 refactor: Move RGB to HSL tests to color_convert_rgb.cpp
31 2022-06-25 0f435906e test: Add tests for RGB to HSL (#691)
32 2022-06-25 526c89833 test: Add tiled TIFF test case to simple_all_formats
33 2022-06-25 b9e652dce fix: Automatic detection of header (#684)
34 2022-06-26 151fd9c8a refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers (#685)
35 2022-06-26 bfed3de00 refactor: Deprecate apply_operation in favor of variant2::visit for any_image (#656)
36 2022-06-26 adddbec89 refactor: Ellipse rasterizer according to the comment at (#692)
37 2022-06-27 d5492e1ac feat: Added apply_rasterizer() free function (#695)
38 2022-06-27 95679b628 docs!: Announce plan to require C++17 after Boost 1.80 (#694)
39 2022-06-27 103f4d31b build: Update CMAKE_CXX_STANDARD from 11 to 14
40 2022-06-27 156dd29f2 build: Bump Boost required by CMake from 1.72 to 1.80
41 2022-06-27 fe63aa2a1 refactor: Switch to trailing return types (#599)
42 2022-06-27 1049c0719 build: Fix CMake source file extensions must be explicit
43 2022-06-27 27826a7d5 ci: Remove C++11 build jobs after C++14 switch (#698)
44 2022-06-27 2faf52f23 Merge pull request #699 from mloskot/ml/cmake-bump-cxxstd-11-to-14
45 2022-06-27 5c3cfc7f7 docs: Bump C++11 to C++14 as current required (#700)
46 2022-06-27 8d7034c71 fix: Memory leak in image class for empty dimensions (#649)
47 2022-06-28 a0ac9fb4a test: Case test_constructor_from_view was not called
48 2022-06-28 ef9b89a93 test: Add test cases for image with empty dimensions (#702)
49 2022-06-28 4dbf35a51 Add pmr image typedefs (#529)
50 2022-06-29 8101595ce chore: Update CMake to use latest cmake-conan/0.18.1 [ci skip]
51 2022-06-29 00423cca0 chore: Update CMakeSettings.json sample [ci skip]
52 2022-06-29 08e3e6dad test: Add basic is_1d_traversable cases for image_view
53 2022-06-29 7b7c786c1 test: Check more properties of indexed_image_view from extension/toolbox
54 2022-06-29 86ee473f5 test: Add virtual_2d_locator fixture; is_2d_traversable test case
55 2022-06-29 2409be4bd test: Add more basic cases for image class (#423)
56 2022-07-02 233dc53ff fix: Unused variable warning (#704)
57 2022-07-02 fdefeab38 docs: fixed gradient tutorial (#703)
58 2022-07-04 573ba132c fix: broken build for midpoint_ellipse_rasterizer::draw_curve (#705)
59 2022-07-05 eb161402e docs: Updated readme language badge to C++14 (#707) [ci skip]

mloskot added a commit that referenced this issue Jul 5, 2022
@mloskot
Copy link
Member Author

mloskot commented Jul 5, 2022

I think we are good now and on time before the Boost super-project master closes for all changes on the 6th of June.

@striezel
Copy link
Contributor

striezel commented Jul 19, 2022

6. [ ]  Copy release notes to https://github.com/boostorg/website/

Now might be a good time to do that. The Boost 1.80.0 beta 1 has been released last week and the release notes are up on the website, but they show no changes for GIL - so far. Considering that GIL in Boost 1.80.0 brings a lot of changes - among them a breaking by switching to C++14 - those changes should be made visible on the website.

As far as I understand somebody has to create a PR on the website repository to update those notes, so I took the liberty to do that: boostorg/website#696 Somebody (@mloskot?) should still check the syntax, though, because that's the first time I have written something in QuickBook format.

@mloskot
Copy link
Member Author

mloskot commented Jul 20, 2022

@striezel Yes, I meant to do it sooner but I've got swamped with other stuff. So, thank you for the golden helping hand with the PR. I will check it.

UPDATE: Done, boostorg/website#696 merged.

@mloskot
Copy link
Member Author

mloskot commented Aug 11, 2022

We're done here. Congratulations and thanks to every one involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants