refactor: Renamed io/dynamic_io_new.hpp to io/detail/dynamic.hpp #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
changed the title
6 tasks
|
I guess I am a bit late, but this commit seems to be the one breaking the build for me. In all of the |
|
|
2 tasks
mloskot
pushed a commit
that referenced
this pull request
May 13, 2022
The error was due to missing dynamic.hpp (renamed in #653) header that contained dynamic_io_fnobj. Adding the header back in to write.hpp headers of io extensions fixed the problem.
faithandbrave
added a commit
to faithandbrave/website
that referenced
this pull request
Jul 30, 2022
s/construct_method/construct_matched/ boostorg/gil#653
striezel
added a commit
to striezel-stash/gil
that referenced
this pull request
Aug 2, 2022
That typo was already fixed for the Boost website in commit <boostorg/website@be79716>, but the change has not made it back to GIL - yet. [ci skip]
1 task
mloskot
pushed a commit
that referenced
this pull request
Aug 2, 2022
That typo was already fixed for the Boost website in commit <boostorg/website@be79716>, but the change has not made it back to GIL - yet. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed
io/dynamic_io_new.hpptoio/detail/dynamic.hpp.The function
construct_matchedwas only used by other detail headers, thus I moved the function into the detail namespace as already suggested in the issue. Additionally I moved the whole file into the detail directory, because it only contains details now.References
Fixes #189
Tasklist