Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large number of examples use interfaces that have been removed #146

Open
jzmaddock opened this issue Dec 16, 2018 · 0 comments
Open

Large number of examples use interfaces that have been removed #146

jzmaddock opened this issue Dec 16, 2018 · 0 comments

Comments

@jzmaddock
Copy link
Contributor

The following files:

kruskal-telephone.cpp ;
loops_dfs.cpp ;
scc.cpp ;
reachable-loop-head.cpp ;
cc-internet.cpp ;
reachable-loop-tail.cpp ;
prim-telephone.cpp ;
dfs-parenthesis.cpp ;
edge_connectivity.cpp ;
edge-connectivity.cpp ;

All use GraphvizGraph and related interfaces which have been removed from the library - actually they are commented out with the note:

  // This interface has not worked for a long time

So either we need to remove these examples altogether, or better, figure out what interface they should be using.

In addition strong_components.cpp calls an old Graphviz API whose meaning has changed - as a result it chokes interpreting a filename as Graphviz data. Replacing the filename with a std::ifstream just moves the error elsewhere :(

deinst added a commit to deinst/graph that referenced this issue Jan 30, 2019
part of the fix for github boostorg#146.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant