Merge develop to master #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert post-conditions of calling `iconv` and add test for a possible violation of that.
Use a better name for a type-erased string implemented using `dynamic_cast` instead of storing&comparing the `typeid` of the char type used. This is a workaround for missing typeinfo for `char8_t` on e.g. libc++ on FreeBSD 13.1. It also simplifies memory management size calc/copy implementation.
Including ICU might bring another Iconv in (e.g. on FreeBSD) which has different symbols. So check for Iconv after adding the ICU options
The old MinGW32 doesn't properly support C++11
Reproducer for crash due to type confusin as reported in #210 (comment)
The value is always non-NULL so return a reference instead.
The default level is "identical" not "primary". Also fix some typos in the documentation.
As documented this should throw on construction not on use.
- Remove single-use local variables - Use nullptr instead of 0 - Assert return value
The class derived from `std::collate` which is always present in `std::locale`. So checks for the `boost::locale::collator` facet may return wrongly true. As a fix make this an independent facet with its own ID. Use an adapter such that a std::collate derived class can use its abilities.
ICU is linked against libc++ causing a crash when using GCC which by default uses libstc++ causing symbol conflicts in the standard library.
In the en_US.ISO8859-1 'ç' and 'Ç' should be case-converted into each other but on FreeBSD this doesn't seem to happen. This isn't a bug in our library so just detect this.
False positives on drone.
Segfaults in most tests, likely related to ICU. Not worth the effort
They hang indefinitely, potentially due to #206
Fix possible type confusion with `boost::locale::collator`
Remove magic numbers Add const
In the en_US.ISO8859-1 'ç' and 'Ç' should be case-converted into each other but on FreeBSD this doesn't seem to happen. This isn't a bug in our library so just detect this.
Add Drone CI
This reverts commit 116b589.
E2BIG shall be returned if the output buffer is too small. We pass a 64 byte buffer which should be enough to do *something* However it is observed on MacOS Sonoma that iconv returns E2BIG without doing any progress leading to an infinite loop as the same inputs will be passed over and over. See #206. Instead raise an exception when this case is detected.
Iconv still fails to behave correctly: - Testing correct invalid bytes skipping -- UTF-8 --- At start single ----- [IConv] --- At start multiple ----- [IConv] --- At middle single Error in line 167: to_utf<Char>(source, encoding) == target ---- [g] != [grU+00FCU+00DFen] Error in line 77: conv(source) == target ---- [g] != [grU+00FCU+00DFen] ----- [IConv] Error in line 85: convPtr->convert(source) == target ---- [g] != [grU+00FCU+00DFen] and: -- Error for decoding to UTF-8 Error in line 188: from_utf<Char>(source, encoding) == target ---- [gr�����üßen] != [grüßen]
Catch OSX sonoma iconv issue
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 95.63% 95.72% +0.09%
==========================================
Files 114 116 +2
Lines 10138 9937 -201
==========================================
- Hits 9695 9512 -183
+ Misses 443 425 -18
... and 49 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.