Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random search #1071

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Random search #1071

merged 1 commit into from
Jan 25, 2024

Conversation

NAThompson
Copy link
Collaborator

No description provided.

@NAThompson NAThompson force-pushed the random_search branch 3 times, most recently from 696adb3 to 01f63f8 Compare January 24, 2024 18:01
@NAThompson NAThompson marked this pull request as ready for review January 24, 2024 18:01
@NAThompson NAThompson changed the title [CI SKIP][ci skip] Random search Random search Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (31b76ee) 85.22% compared to head (34d5e13) 85.22%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1071   +/-   ##
========================================
  Coverage    85.22%   85.22%           
========================================
  Files          877      879    +2     
  Lines        66819    66899   +80     
========================================
+ Hits         56948    57018   +70     
- Misses        9871     9881   +10     
Files Coverage Δ
include/boost/math/optimization/jso.hpp 81.21% <100.00%> (ø)
test/cardinal_cubic_b_spline_test.cpp 100.00% <100.00%> (ø)
test/differential_evolution_test.cpp 59.70% <100.00%> (ø)
test/fourier_transform_daubechies_test.cpp 96.80% <ø> (-0.03%) ⬇️
test/gauss_quadrature_test.cpp 94.92% <100.00%> (+0.03%) ⬆️
test/random_search_test.cpp 100.00% <100.00%> (ø)
test/test_functions_for_optimization.hpp 100.00% <ø> (ø)
test/math_unit_test.hpp 24.00% <12.50%> (ø)
include/boost/math/optimization/random_search.hpp 72.72% <72.72%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b76ee...34d5e13. Read the comment docs.

@NAThompson NAThompson force-pushed the random_search branch 10 times, most recently from 8a3eb6a to 1057b37 Compare January 24, 2024 23:09
@NAThompson NAThompson merged commit fccad84 into develop Jan 25, 2024
69 of 70 checks passed
@NAThompson NAThompson deleted the random_search branch January 25, 2024 01:26
@ckormanyos
Copy link
Member

Hi @NAThompson I just found a random instance of something random that looked very close to expectation and might somehow be related to some of this recent work.

In a completely unrelated CI that had no association with this work, I think some runner found a random outlier here.

@NAThompson
Copy link
Collaborator Author

@ckormanyos : Bah, I thought I'd fixed that one. Hopefully fixed permanently here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants