Fix: adapt to renaming of serialization::array_wrapper #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e3b67eb299b070edb32c2eb5da76653b4ed9cf5e in Boost.Serialization renames serialization::array to serialization::array_wrapper.
| @@ -42,7 +42,7 @@ class forward_iprimitive | |||
|
|
|||
| /// loading of arrays is forwarded to the implementation archive | |||
| template<class T> | |||
| void load_array(serialization::array<T> & x, unsigned int file_version ) | |||
| void load_array(serialization::array_wrappe<T> & x, unsigned int file_version ) | |||
There was a problem hiding this comment.
Missing 'r'? Is this code exercised by any tests?
There was a problem hiding this comment.
On 25/04/2016 09:17, Vladimir Prus wrote:
In include/boost/mpi/detail/forward_iprimitive.hpp
#30 (comment):@@ -42,7 +42,7 @@ class forward_iprimitive
/// loading of arrays is forwarded to the implementation archive template<class T>
- void load_array(serialization::array & x, unsigned int file_version )
- void load_array(serialization::array_wrappe & x, unsigned int file_version )
Missing 'r'? Is this code exercised by any tests?
Does not ring any bell. Wasn't even aware serialization arrays were
renamed or handled.
Alain
There was a problem hiding this comment.
The code is obviously not exercised. The tests are all green if the patch is applied. So I guess test is needed then.
|
Applied patch e4be441 to fix this as it could impact users. I'll add a ticket to add a test to exercise this code. |
Belcourt
pushed a commit
that referenced
this pull request
Apr 26, 2016
Fix: adapt to renaming of serialization::array_wrapper Tested that both graph_parallel and MPI work fine with El Capitan and clang, thanks for the patch!
Belcourt
added a commit
that referenced
this pull request
Apr 27, 2016
Fix my previous cherry-picks with a whitespace change to force the merge. * doc: Fix typos * Fix: adapt to renaming of serialization::array_wrapper (#30) Fix: adapt to renaming of serialization::array_wrapper Tested that both graph_parallel and MPI work fine with El Capitan and clang, thanks for the patch! * Fix typo with rename to array_wrapper. * Whitespace change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e3b67eb299b070edb32c2eb5da76653b4ed9cf5e in Boost.Serialization
renames serialization::array to serialization::array_wrapper.