Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rooted_allocator claiming to be always_equal. #9

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@BillyONeal
Copy link

BillyONeal commented Nov 29, 2018

rooted_allocator is picking up std::allocator's operator==, operator!=, and is_always_equal==true by deriving from std::allocator, but it injects state that needs to be checked for equality. This change adds is_always_equal=false, and the missing comparison operators.

Fixed rooted_allocator claiming to be always_equal.
rooted_allocator is picking up std::allocator's operator==, operator!=, and is_always_equal==true by deriving from std::allocator, but it injects state that needs to be checked for equality. This change adds is_always_equal=false, and the missing comparison operators.
@joaquintides

This comment has been minimized.

Copy link
Member

joaquintides commented Dec 22, 2018

Thanks for the report. I've refactored the allocator handling code so as to support your use case and many other alternatives: 78e8a8e...5af64d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.