Fix compatibility with Python 3.10.0a4: fopen #344
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace private _Py_fopen() with public fopen(): private _Py_fopen() function was removed in 3.10.0a4: https://bugs.python.org/issue32381
|
Fedora downstream issue: https://bugzilla.redhat.com/show_bug.cgi?id=1912903 |
|
If Boost needs a public C API for https://www.python.org/dev/peps/pep-0446/ please ask for it :-) But it would be a new Python feature. In general, third party projects should not rely on private functions, or be prepared for breakage at new Python version. |
|
Thanks ! |
This was referenced Jan 20, 2021
8 tasks
gmloose
pushed a commit
to lofar-astron/PyBDSF
that referenced
this pull request
Oct 31, 2022
And bump Boost version to fix removal of deprecated function: boostorg/python#344
jakobandersen
added a commit
to jakobandersen/mod
that referenced
this pull request
Nov 27, 2022
Due to boostorg/python#344 for Python 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace private _Py_fopen() with public fopen(): private _Py_fopen()
function was removed in 3.10.0a4:
https://bugs.python.org/issue32381