Lex: Fixed C2001 'newline in constant' warning in generated lexers #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes https://svn.boost.org/trac10/ticket/11540. Actually this should have been caught by `regression_matlib_generate_switch` test, but it is not complex enough to cover all cases. We do not have the coverage reports yet, but the fix is trivial so I think it is ok.
|
Could you explain what you had in mind with this patch, please? From what I see you're now comparing against a multi-character literal - is that legal in the first place? |
|
Sorry, I take that back - I see now what you're doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://svn.boost.org/trac10/ticket/11540.
Actually this should have been caught by
regression_matlib_generate_switchtest, but it is not complex enough to cover all cases. We do not have the
coverage reports yet, but the fix is trivial so I think it is ok.