Improve what() info for distinct directive #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like on similar directives, propagate the info from the subject parser for improved debug/diagnostics.
|
"The Travis CI build is in progress"... will this ever finish?... :-/ |
|
"The Travis CI build is in progress"... Sigh... I'll take the chance and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like on similar directives, propagate the info from the subject parser
for improved debug/diagnostics.
The idea taken from and demonstrated here: https://stackoverflow.com/questions/65087474/how-to-get-boost-spirit-build-in-error-message-distinct-possible-symbols/65098082#65098082
With this change, user won't need to tediously create a custom
my_distinctdirective just to override thewhat()behaviour.