-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOOST_TEST_CHECK can't compare abstract classes using gcc #209
Milestone
Comments
I've made a fix, annoyingly the problem does not happen on clang/OSX. Waiting for CI checks. |
Would it be possible for you to check the branch |
That branch works for me. |
raffienficiaud
added a commit
that referenced
this issue
Jul 21, 2019
Fixes GH-209. A new helper meta-function has been added to check if the type under test is complete or not. Incomplete types cannot be used with std::numeric_limits. The newly added test cannot be run on pre C++11 because of the limited BOOST_TEST support (unrelated to the std::numeric_limits issue).
raffienficiaud
added a commit
that referenced
this issue
Jul 21, 2019
…xt-internal * topic/GH-209-BOOST_TEST-abstract-class-compare: Change log Helper for restricting the use of numeric_limits to complete types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Godbolt. When compiling this code, GCC complains that it can't instantiate the member functions of
std::numeric_limits
with an abstract type. Boost Test should check ifnumeric_limits
is instantiable with a specific type before attempting to instantiate it; see https://stackoverflow.com/questions/16505782/determining-if-stdnumeric-limitst-is-safe-to-instantiate for a longer discussion of the issue and possible implementations.The text was updated successfully, but these errors were encountered: