Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninitilized variable in framework_init_observer_t #286

Closed
wants to merge 2 commits into from

Conversation

K-os
Copy link
Contributor

@K-os K-os commented Oct 7, 2020

fixes: #272

@vakatov
Copy link

vakatov commented Dec 1, 2021

Did this fix fall through the cracks? It fixes problem for us but... still not in the releases. Without the fix, we are stuck with 1.72.0 (or, internally, with patched Boost 1.73.0+).

@K-os
Copy link
Contributor Author

K-os commented Feb 21, 2022

I think this project is dead.

The number of open issues is growing and the only ones closed in the last year were closed by the reporters themselves. Also no PRs were merged for over a year.

@raffienficiaud
Copy link
Member

The project is not dead.

@vakatov
Copy link

vakatov commented Feb 22, 2022

Are there plans to deal with this bug? It was identified 1.5 years ago, and it clearly affects more than one user.

FWIW, I find it hard to believe that the (extremely trivial) two PRs to fix this bug can be blamed for any regressions.

@raffienficiaud
Copy link
Member

Yes, the CI was dead since I moved from my previous job and now I fixed it. Travis and Appveyor are just not working.
I will fix the current issues on develop and run the CI on this one. This should be done in the next couple of days.

@raffienficiaud raffienficiaud added this to the 1.79 milestone Mar 1, 2022
raffienficiaud added a commit that referenced this pull request Mar 1, 2022
…erver_t-uninit-var

Topic/gh 286 framework init observer t uninit var
@raffienficiaud
Copy link
Member

Fixed through #328 rev 194a69e

@raffienficiaud
Copy link
Member

Thank you for the patch!

@vakatov
Copy link

vakatov commented Mar 1, 2022

Great, thanks much @K-os and @raffienficiaud!

@K-os
Copy link
Contributor Author

K-os commented Mar 2, 2022

Good to see progress in this project. Thanks for maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninitialized memory in framework_init_observer_t
3 participants