Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Bug in boost::condition_variable on Windows #130

Closed
panyusko opened this issue Aug 23, 2017 · 3 comments
Closed

windows: Bug in boost::condition_variable on Windows #130

panyusko opened this issue Aug 23, 2017 · 3 comments
Labels
Milestone

Comments

@panyusko
Copy link

The bug was made in commit ace2b8f (see line 247)

// do it here to avoid throwing on the destructor
entry->remove_waiter();

Instead should be entry.remove_waiter(); because of entry_manager has overloaded operator -> and the function is called on basic_cv_list_entry but not entry_manager itself. This results in synchronization issues.

@viboes
Copy link
Collaborator

viboes commented Aug 24, 2017

I suspect that this was already fixed, isn't it?

@viboes viboes changed the title Bug in boost::detail::basic_condition_variable on Windows Bug in boost::condition_variable on Windows Aug 24, 2017
@viboes
Copy link
Collaborator

viboes commented Aug 24, 2017

You are right. Using the same name for the function was an source of errors.

Thanks for catching this.

@viboes viboes added the bug label Aug 24, 2017
@viboes viboes changed the title Bug in boost::condition_variable on Windows windows: Bug in boost::condition_variable on Windows Aug 24, 2017
@viboes viboes added this to the 1.66 milestone Aug 26, 2017
@viboes
Copy link
Collaborator

viboes commented Aug 26, 2017

a02f0ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants