Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on deprecated type_traits implementation details #17

Merged
merged 1 commit into from
May 31, 2015
Merged

Conversation

jhunold
Copy link
Contributor

@jhunold jhunold commented May 27, 2015

ice_or and and ice_and are workaround for non-conforming compilers.
So just use operator || and && instead.

Compiles and works with clang trunk + libc++ on linux.

ice_or and and ice_and are workaround for non-conforming compilers.
So just use operator || and && instead.
@mkurdej
Copy link
Member

mkurdej commented May 28, 2015

Looks good. However I've tested it on Win8, MSVC2013, 32-bit & 64-bit and I get an error (but probably it's unrelated to your changes):

Entering test case "test_output_autoprefixed_quantity_name"
unknown location(0): fatal error in "test_output_autoprefixed_quantity_name": unrecognized exception. Id: 0xc00002b5
test_output.cpp(337): last checkpoint

in both 32-bit and 64-bit.

@jhunold
Copy link
Contributor Author

jhunold commented May 28, 2015

@mkurdej Thanks for testing. Will try with msvc-12.0 tomorrow. I've already tested with 14.0-RC, everything works.

@jhunold
Copy link
Contributor Author

jhunold commented May 28, 2015

@mkurdej Tested with msvc-9.0, 10.0, 11.0 and 12.0 in 32- and 64-bit, all tests pass.
One exception is a failure in the regex for detecting quiet NaNs, but this is another topic.
Will commit the patch on Sunday if no-one objects.

jhunold added a commit that referenced this pull request May 31, 2015
Remove dependency on deprecated type_traits implementation details
@jhunold jhunold merged commit 0d2d5df into boostorg:develop May 31, 2015
@jhunold jhunold deleted the ice branch May 31, 2015 19:02
jbakosi added a commit to quinoacomputing/quinoa that referenced this pull request Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants