Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement __has_include() #102

Merged
merged 16 commits into from
Jun 27, 2020
Merged

Implement __has_include() #102

merged 16 commits into from
Jun 27, 2020

Conversation

jefftrull
Copy link
Collaborator

@jefftrull jefftrull commented Jun 24, 2020 •
edited
Loading

Implement C++17 feature (and vendor extension, previously) __has_include()

Includes feature flags and unit tests.

@jefftrull jefftrull requested a review from hkaiser June 24, 2020 21:55
@jefftrull
Make const data member compatible with C++03
c4af1e1
@jefftrull
Move whitespace trim code into common header
119bce9
@jefftrull
Ensure comment/blank skipper is run one last time before the end
2322e03 
I wanted to be sure the parser liked all the input and not just some
preamble, but this is a better approach than testing for all input consumed.
@jefftrull
Fixed include guard comments I messed up
eb081f9 
global query-replace "defined" to "has_include" had unexpected side effects
@jefftrull
Add copyright note for me
b8beb18 
I gotta be in here somewhere, I guess
@jefftrull
Introduce unit tests for __has_include
0b6df31
@jefftrull
Add test for inhibiting redefining __has_include
6dc21c8
hkaiser
hkaiser reviewed Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test that uses __has_include() in a pre-C++20 setting making sure it has no special meaning in this case?

@jefftrull jefftrull marked this pull request as ready for review June 26, 2020 21:54
@jefftrull jefftrull changed the title WIP: __has_include Implement __has_include() Jun 26, 2020
@jefftrull
Copy link
Collaborator Author

I'm satisfied with the code at this point and am just waiting for CI to finish. Will wait for any final feedback.

@jefftrull jefftrull merged commit ee0a7c1 into boostorg:develop Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jefftrull @hkaiser